Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DCJ-212] Refactor ResearcherInfo.js to JSX #2560

Merged
merged 5 commits into from
May 6, 2024
Merged

Conversation

PintoGideon
Copy link
Contributor

Addresses

https://broadworkbench.atlassian.net/browse/DCJ-212

Summary

  1. Remove the use of react-hyperscript-helpers
  2. Update the file extension from js to jsx

Have you read Terra's Contributing Guide lately? If not, do that first.

  • Label PR with a Jira ticket number and include a link to the ticket
  • Label PR with a security risk modifier [no, low, medium, high]
  • PR describes scope of changes
  • Get a minimum of one thumbs worth of review, preferably two if enough team members are available
  • Get PO sign-off for all non-trivial UI or workflow changes
  • Verify all tests go green
  • Test this change deployed correctly and works on dev environment after deployment

@PintoGideon PintoGideon requested a review from a team as a code owner May 2, 2024 13:54
@PintoGideon PintoGideon requested review from aarohinadkarni, okotsopoulos and a team and removed request for a team, aarohinadkarni and okotsopoulos May 2, 2024 13:54
@PintoGideon PintoGideon marked this pull request as draft May 2, 2024 14:00
@PintoGideon PintoGideon marked this pull request as ready for review May 2, 2024 14:35
Copy link
Contributor

@rushtong rushtong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works as expected, I didn't find any regressions. See optional minor comments inline.

src/pages/dar_application/ResearcherInfo.jsx Outdated Show resolved Hide resolved
src/pages/dar_application/ResearcherInfo.jsx Outdated Show resolved Hide resolved
src/pages/dar_application/ResearcherInfo.jsx Outdated Show resolved Hide resolved
Copy link
Contributor

@aarohinadkarni aarohinadkarni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, everything works as expected 👍

Copy link
Contributor

@rushtong rushtong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the changes 👍🏽

@PintoGideon PintoGideon merged commit 92a00ff into develop May 6, 2024
9 checks passed
@PintoGideon PintoGideon deleted the gp-dcj-212 branch May 6, 2024 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants