Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DCJ-200] Refactor FAQs.js to JSX #2561

Merged
merged 3 commits into from
May 6, 2024
Merged

[DCJ-200] Refactor FAQs.js to JSX #2561

merged 3 commits into from
May 6, 2024

Conversation

PintoGideon
Copy link
Contributor

@PintoGideon PintoGideon commented May 2, 2024

Addresses

https://broadworkbench.atlassian.net/browse/DCJ-200

Summary

  1. Remove the use of react-hyperscript-helpers
  2. Remove unused code
  3. Update the file ext from js to jsx
  4. Delete the file as it is not referenced by any routes or components.

Have you read Terra's Contributing Guide lately? If not, do that first.

  • Label PR with a Jira ticket number and include a link to the ticket
  • Label PR with a security risk modifier [no, low, medium, high]
  • PR describes scope of changes
  • Get a minimum of one thumbs worth of review, preferably two if enough team members are available
  • Get PO sign-off for all non-trivial UI or workflow changes
  • Verify all tests go green
  • Test this change deployed correctly and works on dev environment after deployment

@PintoGideon PintoGideon requested a review from a team May 2, 2024 16:14
@PintoGideon PintoGideon requested a review from a team as a code owner May 2, 2024 16:14
@PintoGideon PintoGideon requested review from aarohinadkarni and okotsopoulos and removed request for a team, aarohinadkarni and okotsopoulos May 2, 2024 16:14
Copy link
Contributor

@rushtong rushtong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏽 Side note, there are no links or routes to this page - I'm thinking this is a very outdated page as there is an external FAQs page here: https://broad-duos.zendesk.com/hc/en-us/articles/360059957092-Frequently-Asked-Questions-FAQs-

@fboulnois
Copy link
Contributor

fboulnois commented May 3, 2024

👍🏽 Side note, there are no links or routes to this page - I'm thinking this is a very outdated page as there is an external FAQs page here: https://broad-duos.zendesk.com/hc/en-us/articles/360059957092-Frequently-Asked-Questions-FAQs-

Should we simply remove this page? We can always restore it from git history if necessary.

@rushtong
Copy link
Contributor

rushtong commented May 3, 2024

👍🏽 Side note, there are no links or routes to this page - I'm thinking this is a very outdated page as there is an external FAQs page here: https://broad-duos.zendesk.com/hc/en-us/articles/360059957092-Frequently-Asked-Questions-FAQs-

Should we simply remove this page? We can always restore it from git history if necessary.

@PintoGideon That's a better idea, please do remove it 👍🏽

@PintoGideon
Copy link
Contributor Author

Will do @fboulnois @rushtong Thank you both !!

Copy link
Contributor

@rushtong rushtong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update 👍🏽

Copy link
Contributor

@fboulnois fboulnois left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@PintoGideon PintoGideon merged commit d73a0fc into develop May 6, 2024
9 checks passed
@PintoGideon PintoGideon deleted the gp-dcj-200 branch May 6, 2024 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants