Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DCJ-308] Switch tags and lint yaml #2566

Merged
merged 3 commits into from
May 7, 2024
Merged

[DCJ-308] Switch tags and lint yaml #2566

merged 3 commits into from
May 7, 2024

Conversation

fboulnois
Copy link
Contributor

@fboulnois fboulnois commented May 3, 2024 •
edited
Loading

Addresses

https://broadworkbench.atlassian.net/browse/DCJ-308

Summary

Switch to using the DCJ specific version of the dependency update ticket

Have you read Terra's Contributing Guide lately? If not, do that first.

  • Label PR with a Jira ticket number and include a link to the ticket
  • Label PR with a security risk modifier [no, low, medium, high]
  • PR describes scope of changes
  • Get a minimum of one thumbs worth of review, preferably two if enough team members are available
  • Get PO sign-off for all non-trivial UI or workflow changes
  • Verify all tests go green
  • Test this change deployed correctly and works on dev environment after deployment

@fboulnois fboulnois requested a review from a team as a code owner May 3, 2024 16:44
@fboulnois fboulnois requested review from rushtong and aarohinadkarni and removed request for a team May 3, 2024 16:44
rushtong
rushtong approved these changes May 3, 2024
View reviewed changes
Copy link
Contributor

@rushtong rushtong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏽

@fboulnois fboulnois force-pushed the fb-dcj-308-tag-dependabot-updates branch from 01dfcc3 to d5d1720 Compare May 3, 2024 16:55
@fboulnois fboulnois marked this pull request as draft May 3, 2024 18:23
@fboulnois fboulnois force-pushed the fb-dcj-308-tag-dependabot-updates branch from d5d1720 to e26cca2 Compare May 3, 2024 18:24
@fboulnois fboulnois marked this pull request as ready for review May 6, 2024 15:30
@fboulnois fboulnois requested a review from rushtong May 6, 2024 15:30
@fboulnois fboulnois changed the title [DCJ-308] Switch tags and tag security updates [DCJ-308] Switch tags and lint yaml May 6, 2024
rushtong
rushtong approved these changes May 6, 2024
View reviewed changes
Copy link
Contributor

@rushtong rushtong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏽

aarohinadkarni
aarohinadkarni approved these changes May 6, 2024
View reviewed changes
Copy link
Contributor

@aarohinadkarni aarohinadkarni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@fboulnois fboulnois merged commit 82a068c into develop May 7, 2024
10 checks passed
@fboulnois fboulnois deleted the fb-dcj-308-tag-dependabot-updates branch May 7, 2024 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rushtong rushtong rushtong approved these changes

@aarohinadkarni aarohinadkarni aarohinadkarni approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fboulnois @rushtong @aarohinadkarni