Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DCJ-110] Workaround which sets viewport size to avoid error #2569

Merged
merged 1 commit into from
May 7, 2024

Conversation

fboulnois
Copy link
Contributor

@fboulnois fboulnois commented May 6, 2024

Addresses

https://broadworkbench.atlassian.net/browse/DCJ-110

Summary

Fixes flaky tests with a workaround which sets the viewport size so that notifications don't overlap the clicked buttons and cause an error.


Have you read Terra's Contributing Guide lately? If not, do that first.

  • Label PR with a Jira ticket number and include a link to the ticket
  • Label PR with a security risk modifier [no, low, medium, high]
  • PR describes scope of changes
  • Get a minimum of one thumbs worth of review, preferably two if enough team members are available
  • Get PO sign-off for all non-trivial UI or workflow changes
  • Verify all tests go green
  • Test this change deployed correctly and works on dev environment after deployment

@fboulnois fboulnois requested a review from a team as a code owner May 6, 2024 17:30
@fboulnois fboulnois requested review from rushtong and aarohinadkarni and removed request for a team May 6, 2024 17:30
Copy link
Contributor

@rushtong rushtong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, thank you 👍🏽
On a side note, there's likely a way for us to debug these kinds of problems more quickly if we integrated with cloud cypress. Here is an example from jade data ui: https://cloud.cypress.io/projects/e6ttjx/runs/3469/specs

Copy link
Contributor

@aarohinadkarni aarohinadkarni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome 👍

@fboulnois
Copy link
Contributor Author

This is great, thank you 👍🏽 On a side note, there's likely a way for us to debug these kinds of problems more quickly if we integrated with cloud cypress. Here is an example from jade data ui: https://cloud.cypress.io/projects/e6ttjx/runs/3469/specs

I created https://broadworkbench.atlassian.net/browse/DCJ-315 to address this issue.

@fboulnois fboulnois merged commit 3a39a44 into develop May 7, 2024
9 checks passed
@fboulnois fboulnois deleted the fb-dcj-110-fix-flaky-tests branch May 7, 2024 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants