Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DCJ-287] Add bulk DAA operations to dropdown on SO Console #2572

Conversation

aarohinadkarni
Copy link
Contributor

Addresses

https://broadworkbench.atlassian.net/browse/DCJ-287

Summary

Adds the dropdown in the header columns allowing a Signing Official to apply or remove one specific DAA specific DAA to all users at once.

Note: this PR depends on this open PR.


Have you read Terra's Contributing Guide lately? If not, do that first.

  • Label PR with a Jira ticket number and include a link to the ticket
  • Label PR with a security risk modifier [no, low, medium, high]
  • PR describes scope of changes
  • Get a minimum of one thumbs worth of review, preferably two if enough team members are available
  • Get PO sign-off for all non-trivial UI or workflow changes
  • Verify all tests go green
  • Test this change deployed correctly and works on dev environment after deployment

@aarohinadkarni aarohinadkarni requested a review from a team as a code owner May 7, 2024 18:57
@aarohinadkarni aarohinadkarni requested review from rushtong and okotsopoulos and removed request for a team May 7, 2024 18:57
@rushtong
Copy link
Contributor

rushtong commented May 8, 2024

Seeing the same new error in this branch as the one it is based from:

SimpleButton.jsx:49 Warning: A props object containing a "key" prop is being spread into JSX:
  let props = {key: someKey, style: ..., id: ..., onClick: ..., onMouseEnter: ..., onMouseLeave: ..., children: ...};
  <button {...props} />
React keys must be passed directly to JSX without using spread:
  let props = {style: ..., id: ..., onClick: ..., onMouseEnter: ..., onMouseLeave: ..., children: ...};
  <button key={someKey} {...props} />
    at SimpleButton (https://local.broadinstitute.org:3000/static/js/bundle.js:8509:5)
    at div
    at Actions (https://local.broadinstitute.org:3000/static/js/bundle.js:12942:5)
    at div
    at div
    at DataRows (https://local.broadinstitute.org:3000/static/js/bundle.js:8808:5)
    at div
    at div
    at SimpleTable (https://local.broadinstitute.org:3000/static/js/bundle.js:8901:5)
    at DarCollectionTable (https://local.broadinstitute.org:3000/static/js/bundle.js:13695:101)
    at div
    at AdminManageDarCollections (https://local.broadinstitute.org:3000/static/js/bundle.js:29272:88)

@rushtong
Copy link
Contributor

rushtong commented May 8, 2024

Seeing something similar which is related to this PR:

Warning: validateDOMNesting(...): <th> cannot appear as a child of <ul>.
    at th
    at ul
    at ManageDaasDropdown (https://local.broadinstitute.org:3000/static/js/bundle.js:51894:82)
    at li
    at div
    at div
    at ColumnRow (https://local.broadinstitute.org:3000/static/js/bundle.js:8702:5)
    at div
    at div
    at SimpleTable (https://local.broadinstitute.org:3000/static/js/bundle.js:8901:5)
    at ManageResearcherDAAsTable (https://local.broadinstitute.org:3000/static/js/bundle.js:52446:95)
    at div
    at div
    at ManageResearcherDAAs (https://local.broadinstitute.org:3000/static/js/bundle.js:52164:96)
    at div
    at div
    at SigningOfficialDaaAgreementWrapper (https://local.broadinstitute.org:3000/static/js/bundle.js:8328:5)

Copy link
Contributor

@rushtong rushtong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this, it works as designed. Once console warnings are addressed, 👍🏽

Copy link
Contributor

@fboulnois fboulnois left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few suggestions:

Copy link
Contributor

@rushtong rushtong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the changes 👍🏽

Copy link
Contributor

@fboulnois fboulnois left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍

@aarohinadkarni aarohinadkarni merged commit b41729d into an-DCJ-286-UI-Update-SO-Console-Add-Bulk-User-Operation-Dropdown May 9, 2024
5 checks passed
@aarohinadkarni aarohinadkarni deleted the an-DCJ-287-UI-Update-SO-Console-Add-Bulk-User-Operation-Dropdown branch May 9, 2024 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants