Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses
https://broadworkbench.atlassian.net/browse/DCJ-163
Summary
Reviewer notes:
I suggest enabling the "Display the rich diff" option for the markdown file. That will show you what the mermaid diagrams look like:![Screenshot 2024-09-03 at 11 52 31 AM](https://private-user-images.githubusercontent.com/116679/364053734-31a4c586-2d8a-4e98-b207-c3b12746de95.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzk3MjAxMjYsIm5iZiI6MTczOTcxOTgyNiwicGF0aCI6Ii8xMTY2NzkvMzY0MDUzNzM0LTMxYTRjNTg2LTJkOGEtNGU5OC1iMjA3LWMzYjEyNzQ2ZGU5NS5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjUwMjE2JTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI1MDIxNlQxNTMwMjZaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT02YmExYzYzYTQxZjA2MTZkMGU0MTU2YTk2NzU4NDZkN2EwNDZiMDU1NWEyOGRkNmQ3MTk5YzgwYzAwYzc0MmM4JlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCJ9.FCfwYdzFrLRuREwegaXuc7PlF7F6vJqLT_jqPMO3Q20)
If you're viewing this in intellij, look for the Mermaid plugin which supports sequence diagrams.
Notes
The DUOS-branded sign in page still needs to be configured in Consent, but this PR is not blocked on that feature. The customized page is implemented here: https://github.com/broadinstitute/terraform-ap-deployments/pull/1713
Have you read Terra's Contributing Guide lately? If not, do that first.