Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DCJ-700: Update to use correct field name #2683

Merged
merged 1 commit into from
Oct 7, 2024

Conversation

rushtong
Copy link
Contributor

@rushtong rushtong commented Oct 7, 2024

Addresses

https://broadworkbench.atlassian.net/browse/DCJ-700

Summary

Update the component to use the correct field name. In #2646, we changed the dataset lookup to pull from Elastic Search instead of the Datasets APIs in Consent. The two objects are slightly different. A larger refactor is necessary to align the two models that will be addressed separately from this bug.


Have you read Terra's Contributing Guide lately? If not, do that first.

  • Label PR with a Jira ticket number and include a link to the ticket
  • Label PR with a security risk modifier [no, low, medium, high]
  • PR describes scope of changes
  • Get a minimum of one thumbs worth of review, preferably two if enough team members are available
  • Get PO sign-off for all non-trivial UI or workflow changes
  • Verify all tests go green
  • Test this change deployed correctly and works on dev environment after deployment

@rushtong rushtong requested a review from a team as a code owner October 7, 2024 17:00
@rushtong rushtong requested review from fboulnois and okotsopoulos and removed request for a team October 7, 2024 17:00
Copy link
Contributor

@fboulnois fboulnois left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes sense 👍

@rushtong rushtong merged commit afeaa78 into develop Oct 7, 2024
9 checks passed
@rushtong rushtong deleted the gr-DCJ-700-fix-approve/deny-links branch October 7, 2024 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants