Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DCJ-678: Remove alpha json config #2684

Merged
merged 1 commit into from
Oct 9, 2024
Merged

DCJ-678: Remove alpha json config #2684

merged 1 commit into from
Oct 9, 2024

Conversation

rushtong
Copy link
Contributor

@rushtong rushtong commented Oct 7, 2024

Addresses

https://broadworkbench.atlassian.net/browse/DCJ-678

Summary

This PR removes an unused config file that is incorrectly referenced in docs. Note that the usage in the integration test action is changed, but that action is not configured to run and in fact cannot run as is, we need to revamp how we're doing integration testing in BEEs now that DUOS supports B2C authentication.


Have you read Terra's Contributing Guide lately? If not, do that first.

  • Label PR with a Jira ticket number and include a link to the ticket
  • Label PR with a security risk modifier [no, low, medium, high]
  • PR describes scope of changes
  • Get a minimum of one thumbs worth of review, preferably two if enough team members are available
  • Get PO sign-off for all non-trivial UI or workflow changes
  • Verify all tests go green
  • Test this change deployed correctly and works on dev environment after deployment

@rushtong rushtong marked this pull request as ready for review October 7, 2024 20:23
@rushtong rushtong requested a review from a team as a code owner October 7, 2024 20:23
@rushtong rushtong requested review from fboulnois and okotsopoulos and removed request for a team October 7, 2024 20:23
Copy link
Contributor

@rjohanek rjohanek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removal of the alpha file looks good! So there is future work coming to get integration testing running again?

@rushtong
Copy link
Contributor Author

rushtong commented Oct 8, 2024

removal of the alpha file looks good! So there is future work coming to get integration testing running again?

@raejohanek - Yes, we have https://broadworkbench.atlassian.net/browse/DCJ-315 slated for that work.

Copy link
Contributor

@fboulnois fboulnois left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good 👍

@rushtong rushtong merged commit ae95327 into develop Oct 9, 2024
9 checks passed
@rushtong rushtong deleted the gr-DCJ-678-rm-alpha branch October 9, 2024 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants