Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DCJ-666] Update links to DUOS documentation to point to new location #2686

Merged
merged 2 commits into from
Oct 10, 2024

Conversation

cinyecai
Copy link
Contributor

@cinyecai cinyecai commented Oct 9, 2024

Addresses

https://broadworkbench.atlassian.net/browse/DCJ-666

Summary

  • Updated old zendesk documentation links to point to new Terra Support site articles and added a couple new links
  • Updated a couple of tests to match the link changes
  • Changes based on this spreadsheet and this search
  • Note - I'm not exactly sure what the zendesk links in /ajax/Support.js (see search) are for and I couldn't find or access them on the UI so I didn't replace those. Every other instance of a zendesk link should be replaced though Never mind, they're API calls and not documentation links, so they won't be replaced
  • I also might've missed updating some tests, I'm not super familiar with the DUOs testings

Visual Aids

New "Help" and "pre-authorize" links:

Screen.Recording.2024-10-09.at.3.16.44.PM.mov

Have you read Terra's Contributing Guide lately? If not, do that first.

  • Label PR with a Jira ticket number and include a link to the ticket
  • Label PR with a security risk modifier [no, low, medium, high]
  • PR describes scope of changes
  • Get a minimum of one thumbs worth of review, preferably two if enough team members are available
  • Get PO sign-off for all non-trivial UI or workflow changes
  • Verify all tests go green
  • Test this change deployed correctly and works on dev environment after deployment

@cinyecai cinyecai requested a review from a team as a code owner October 9, 2024 19:19
@cinyecai cinyecai requested review from rushtong and fboulnois and removed request for a team October 9, 2024 19:19
Copy link
Contributor

@s-rubenstein s-rubenstein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks reasonable to me. I might suggest asking Victoria if she knows about those other links.

Copy link
Contributor

@fboulnois fboulnois left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good 👍 , one minor suggestion:

The table below allows you to pre-authorize your Institution's users to request access to datasets,
The table below allows you to
<a href="https://support.terra.bio/hc/en-us/articles/28512587249051-How-to-Pre-Authorize-Researchers-to-Submit-Data-Access-Requests-in-DUOS"
id="terra-support-pre-auth-link" target="_blank" rel="noreferrer"> pre-authorize </a> your Institution&apos;s users to request access to datasets,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
id="terra-support-pre-auth-link" target="_blank" rel="noreferrer"> pre-authorize </a> your Institution&apos;s users to request access to datasets,
id="terra-support-pre-auth-link" target="_blank" rel="noreferrer">pre-authorize</a> your Institution&apos;s users to request access to datasets,

Copy link
Contributor

@rushtong rushtong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏽 Thank you!

@cinyecai cinyecai merged commit b23eb8b into develop Oct 10, 2024
9 checks passed
@cinyecai cinyecai deleted the cc-dcj-666-updating-documentation-links branch October 10, 2024 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants