DT-903: Change export button to link directly to terra-ui import page #2711
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pshapiro4broad
requested review from
rjohanek and
cinyecai
and removed request for
a team
fboulnois
approved these changes
Nov 5, 2024
rushtong
approved these changes
Nov 5, 2024
At a minimum we probably want a bit of spacing between the links. |
pshapiro4broad
commented
Nov 5, 2024
| } | ||
|
|
||
| return null; | ||
| const link = `${terraUrl}/#import-data?snapshotId=${snapshot.id}&format=tdrexport&tdrSyncPermissions=false`; |
There was a problem hiding this comment.
Here's the code in TDR which also generates this link for import https://github.com/DataBiosphere/jade-data-repo/blob/develop/src/main/java/bio/terra/service/snapshotbuilder/SnapshotBuilderService.java#L475
The link's behavior is implemented in terra-ui: https://github.com/DataBiosphere/terra-ui/blob/dev/src/import-data/useImportRequest.ts#L95
pshapiro4broad
changed the title
|
I've added spacing between the links. There's not much room for multiple Exports, but we have other tickets for that issue, so I'm not going to address that now. 
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses
https://broadworkbench.atlassian.net/browse/DT-903
Instead of performing a two-step operation in the duos UI, use the new TDR import link to have terra-ui perform the TDR export step. The same APIs are called in both cases, so other than the UX differences there is no difference in behavior.
Summary
Video clip showing behavior, note that this is trying to export an azure dataset so the final step is blocked, but everything else is working correctly.
export.mov