[DT-962] Removes links from the access type column #2713
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
s-rubenstein
requested review from
pshapiro4broad and
cinyecai
and removed request for
a team
snf2ye
approved these changes
Nov 5, 2024
| dataset.accessManagement === 'open' ? | ||
| 'Open Access' : dataset.dac?.dacName, | ||
| value: dataset.accessManagement, | ||
| id: `${dataset.datasetId}-participant-count`, |
There was a problem hiding this comment.
Do you know why the id is named "participant-count" ?
There was a problem hiding this comment.
Probably a copy-paste from a previous column. We should probably give this a unique name.
Comment on lines
+331
to
+335
| data: dataset.accessManagement === 'external' ? | ||
| 'External to DUOS' : | ||
| dataset.accessManagement === 'open' ? | ||
| 'Open Access' : dataset.dac?.dacName, | ||
| value: dataset.accessManagement, |
There was a problem hiding this comment.
What is the difference between data and value?
There was a problem hiding this comment.
Data is what is shown to the user, value is the underlying content of the selection.
fboulnois
approved these changes
Nov 5, 2024
| dataset.accessManagement === 'open' ? | ||
| 'Open Access' : dataset.dac?.dacName, | ||
| value: dataset.accessManagement, | ||
| id: `${dataset.datasetId}-participant-count`, |
There was a problem hiding this comment.
Probably a copy-paste from a previous column. We should probably give this a unique name.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses
Removes links from access type. I decided to move to inlining the ternary because we didn't have a switch utility function - this ideally would be a switch statement.
Summary
Have you read Terra's Contributing Guide lately? If not, do that first.