DT-969: Show server errors when creating a draft DAR #2714
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rushtong
requested review from
snf2ye and
s-rubenstein
and removed request for
a team
fboulnois
approved these changes
Nov 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses
https://broadworkbench.atlassian.net/browse/DT-969
Summary
If there are server errors when submitting a draft dar, they are swallowed by the UI. This PR shows them in the two cases where one can apply for access to a dataset(s).
Data Library View
Screen.Recording.2024-11-05.at.4.31.58.PM.mov
Dataset View
Screen.Recording.2024-11-05.at.4.34.59.PM.mov
Have you read Terra's Contributing Guide lately? If not, do that first.