Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DT-987]Debounce the dataset search and filter in the Data Library #2730

Merged
merged 3 commits into from
Nov 18, 2024

Conversation

rjohanek
Copy link
Contributor

Addresses

Jira ticket: https://broadworkbench.atlassian.net/browse/DT-987

Summary

Add debouncing to the search and filter api call in the data library

Testing

I tested manually as shown in the video, but I am down to add unit tests if we think that would be beneficial. I just wasn't sure how to unit test the debouncing behavior.

Video shows that the api is not called on every keystroke
https://github.com/user-attachments/assets/345e0696-bcac-4d26-a4c4-07dd44e693fd


Have you read Terra's Contributing Guide lately? If not, do that first.

  • Label PR with a Jira ticket number and include a link to the ticket
  • Label PR with a security risk modifier [no, low, medium, high]
  • PR describes scope of changes
  • Get a minimum of one thumbs worth of review, preferably two if enough team members are available
  • Get PO sign-off for all non-trivial UI or workflow changes
  • Verify all tests go green
  • Test this change deployed correctly and works on dev environment after deployment

@rjohanek rjohanek requested a review from a team as a code owner November 18, 2024 16:49
@rjohanek rjohanek requested review from rushtong and pshapiro4broad and removed request for a team November 18, 2024 16:49
Copy link
Member

@pshapiro4broad pshapiro4broad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks OK. For a demo video, using a very long debounce time may make it easier to see what's going on.

src/components/data_search/DatasetSearchTable.jsx Outdated Show resolved Hide resolved
Copy link
Contributor

@rushtong rushtong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏽

@rjohanek rjohanek merged commit 7a7047c into develop Nov 18, 2024
9 checks passed
@rjohanek rjohanek deleted the rj-dt-987-debounce branch November 18, 2024 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants