[DT-777] Filter by participant count #2733
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rjohanek
requested review from
pshapiro4broad and
snf2ye
and removed request for
a team
# Conflicts: # src/components/data_search/DatasetFilterList.jsx
pshapiro4broad
approved these changes
Nov 21, 2024
Comment on lines
61
to
62
| } else { | ||
| if (filters[category]) { |
There was a problem hiding this comment.
I would combine an if after an else here
Suggested change
| } else { | |
| if (filters[category]) { | |
| } else if (filters[category]) { |
fboulnois
approved these changes
Nov 21, 2024
There was a problem hiding this comment.
I like most of @pshapiro4broad 's suggestions! The only one I'm not sure about is the filterHandler refactor.
rjohanek
commented
Nov 22, 2024
| import DatasetFilterList from '../../../src/components/data_search/DatasetFilterList'; | ||
|
|
||
| const duosUser = { |
rjohanek
commented
Nov 22, 2024
| {method: 'POST', url: '**/api/dataset/search/index'}, handler).as('searchIndex'); | ||
| mount(<DatasetSearchTable {...props} />); | ||
| cy.get('#participantCountMax-range-input').clear().type('50'); | ||
| cy.wait(1000).then(() => { |
There was a problem hiding this comment.
when I wait on 'searchIndex' it doesn't work I think because there is another call to this api without the filters applied first
# Conflicts: # cypress/component/DataSearch/dataset_search_filters.spec.js
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses
Jira Ticket: https://broadworkbench.atlassian.net/browse/DT-777
Summary
Adds a filter for participant size
DatasetSearchTable:
DatasetFilterList
Visual
Screen.Recording.2024-11-21.at.9.59.40.AM.mov
To Do
Unit tests
Have you read Terra's Contributing Guide lately? If not, do that first.