Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DT-997] Move the Donor Size Header in DUOS further left so it aligns with the rest of the table #2735

Merged
merged 2 commits into from
Nov 22, 2024
Merged

[DT-997] Move the Donor Size Header in DUOS further left so it aligns with the rest of the table #2735

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
09428f1
Increase spacing between Donor Size and Data Location column
cinyecai Nov 21, 2024
82efe1b
Add margin to mitigate issues with resizing window
cinyecai Nov 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions src/components/data_search/DatasetSearchTableConstants.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,14 +25,15 @@ interface DatasetSearchTableTabs {

const makeHeaderStyle = (width: string | number): React.CSSProperties => ({
width,
marginRight: 5
});

const makeRowStyle = (width: string | number): React.CSSProperties => ({
width,
textOverflow: 'ellipsis',
textWrap: 'nowrap',
overflow: 'hidden',
paddingRight: 5
marginRight: 5
});

const trimNewlineCharacters = (str: string): string => str?.replace( /[\r\n]+/gm, '');
Expand Down Expand Up @@ -243,7 +244,7 @@ export const makeDatasetTableHeader = (datasets: DatasetTerm[], selected: number
duosId: '10%',
accessType: '10%',
dataType: '15%',
donorSize: '7%',
donorSize: '10%',
Comment on lines -246 to +247
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Before the total %s equalled 100 when added up (25 + 10 + 10+ 15 + 7 + 13 + 10). Now it's 103%. Is that correct? If this % goes up, maybe another needs to go down?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought that too, but it doesn't seem to cause any weird behavior in the rendering of the table itself, but I'll look more into it

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Widths can be > 100%. It can sometimes lead to overflow issues.

dataLocation: '13%',
dataUse: '10%',
exportToTerra: 100,
Expand Down
Loading