Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AJ-1095 - Fix Publish logic - Enable skipping publish on main branch #7

Merged
merged 1 commit into from
Aug 10, 2023

Conversation

snf2ye
Copy link
Collaborator

@snf2ye snf2ye commented Aug 8, 2023

Once merging the last change, I tested running test action without publishing, but it still ran the publish action. So, I needed to re-work the logic a bit.

Now:

  • Does NOT run publish on PR run OR on one-off dispatch when "publish" is set to false
  • Runs publish when referencing main OR when one-off dispatch has "publish" set to true

image

I wanted to share this logic between jobs and put it in an env variable, but jobs.if doesn't get the env context.
@snf2ye snf2ye force-pushed the sh-aj-1095-missing-logic-gha branch from dc786e9 to 6eeb26b Compare August 8, 2023 19:13
@sonarcloud
Copy link

sonarcloud bot commented Aug 8, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sonarcloud
Copy link

sonarcloud bot commented Aug 8, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@snf2ye snf2ye changed the title AJ-1095 - Fix and move run publish logic AJ-1095 - Fix Publish logic - Enable skipping publish on main branch Aug 9, 2023
@snf2ye snf2ye marked this pull request as ready for review August 9, 2023 14:16
Copy link
Contributor

@calypsomatic calypsomatic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok this time it'll work I promise!

@snf2ye
Copy link
Collaborator Author

snf2ye commented Aug 9, 2023

Ok this time it'll work I promise!

Pinky swear!

@snf2ye snf2ye merged commit b440f1f into main Aug 10, 2023
21 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants