Updated with common schema files and seperated postgres data migration #425
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marikomedlock
requested changes
Jun 2, 2023
service/local-dev/run_server.sh
Outdated
| @@ -21,7 +21,7 @@ while getopts ":av" arg; do | |||
| done | |||
|
|
|||
| export TANAGRA_DATABASE_NAME=tanagra_db | |||
| export TANAGRA_DB_INITIALIZE_ON_START=false | |||
| export TANAGRA_DB_INITIALIZE_ON_START=true | |||
There was a problem hiding this comment.
This is helpful for testing, but please leave it set to false in the main branch. This is the setting we'll deploy with, so I'd like to keep it as the testing default as well.
| @@ -1,9 +1,7 @@ | |||
| databaseChangeLog: | |||
| - changeSet: | |||
| id: avoid_postgres_specific_features | |||
| id: schema_extend | |||
There was a problem hiding this comment.
This changeset file has already been deployed to our test instance (we deploy nightly), so you can't change the name or any of the schema specification for postgres. If you change it to render differently for mariadb/mysql only, then I think that's okay (though I'd want to test to confirm) but changing the postgres rendering will definitely break things.
chenchals
force-pushed
the
chenchals/DT-409-Aou-Tanagra-common-schema-files
branch
from
6d12c40
to
f8613d3
Compare
…y, and criteria_value - since nacent key is a reserved word for mariadb
…mon-schema-files' into chenchals/DT-409-Aou-Tanagra-common-schema-files # Conflicts: # service/src/main/resources/db/changesets/20230602_postgres_data_migrate.yaml # service/src/main/resources/db/changesets/20230602_schema_extend.yaml
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
202305_avoid...yamlto20230602_schema_extend.yamlcolumnDataTypetodropNotNullConstraint_2suffix as there were name-collisions with named constraints in20230410_schema_reset.yamlfile20230602_postgres_data_migrate.yamlwithdbms: postgresqltagkeyandvalueto appropriate:property_keyorcriteria_keyand value toproperty_valueorcriteria_valueOFFSET x LIMIT xtoLIMIT x OFFSET xto be compatible with mariadb