Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ID-1209] Log DRS provider to Bard #120

Merged
merged 2 commits into from
Aug 15, 2024
Merged

[ID-1209] Log DRS provider to Bard #120

merged 2 commits into from
Aug 15, 2024

Conversation

samanehsan
Copy link
Contributor

@samanehsan samanehsan commented Aug 15, 2024 •
edited
Loading

Ticket: https://broadworkbench.atlassian.net/browse/ID-1209

Changes:

  • Get the provider in the DRS API controller (instead of the DrsResolutionService) so that it can be included in the Bard properties for that request.
  • Update the signedUrlService since it also calls drsResolutionService.resolveDrsObject

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@samanehsan samanehsan merged commit c5ade26 into dev Aug 15, 2024
13 checks passed
@samanehsan samanehsan deleted the se/ID-1209-log-provider-to-Bard branch August 15, 2024 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Shakespeared Shakespeared Shakespeared approved these changes

@Ghost-in-a-Jar Ghost-in-a-Jar Ghost-in-a-Jar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@samanehsan @Shakespeared @Ghost-in-a-Jar