CORE-163 end support of googleServiceAccount field #125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
snf2ye
approved these changes
Nov 20, 2024
| @@ -149,11 +149,6 @@ private DrsMetadata fetchObject( | |||
| var accessMethod = AccessMethodUtils.getAccessMethod(drsResponse, drsProvider, cloudPlatform); | |||
| var accessMethodType = accessMethod.map(AccessMethod::getType).orElse(null); | |||
|
|
|||
| if (drsProvider.shouldFetchUserServiceAccount(accessMethodType, requestedFields)) { | |||
There was a problem hiding this comment.
Can the shouldFetchUserServiceAccount method also be removed from DrsProviderInterface?
There was a problem hiding this comment.
eventually, yes. There is a bunch more to remove too.
samanehsan
approved these changes
Nov 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://broadworkbench.atlassian.net/browse/CORE-163
The problem in the ticket stems from ECM not properly purging expired fence service account keys. And because they never get removed, ECM never gets a new one. However, ECM never returns the expired key but returns a 404 instead. This triggers a 404 in DrsHub when the googleServiceAccount field is requested which causes failures in rawls when it is validating DRS URIs and workflows when it tries to resolve.
According to https://broadworkbench.atlassian.net/browse/PREQ-28, we no longer need these keys even though they are requested. Both rawls and cromwell should be able to handle their absence because there are already cases where they don't exist (e.g. kids first which is AWS).
I think it is better to discontinue use than to fix ECM's expiration problem.