Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AN-186 Clean up pools from Google Batch enablement #378

Merged
merged 3 commits into from
Nov 8, 2024

Conversation

jgainerdewar
Copy link
Contributor

@jgainerdewar jgainerdewar commented Nov 7, 2024

This is a follow-on to #367 now that the non-prod pools there have been (mostly) put into use.

  • Update test utils to use new pool version
  • Remove the old versions of pools from pool_schema.yml files
  • Remove ALL resource-config files for unused pools

Questions for reviewers:

  • Do we want to remove resource-config files for older pools? Is this desirable cleanup or am I deleting a useful record?
  • In AN-186 Add pool configs with Google Batch enabled #367 I added new versions of all non-TDR pools in environments I didn't know to be defunct (perf, alpha), because this change should apply to ALL new Terra workspace Google projects. In a couple cases, though, I couldn't find where the pool was used, so I couldn't update that usage to the new pool version. This leaves us with a newer pool with the correct settings, and an older pool that may or may not be in use somewhere, and so can't be removed. What's the best way to handle this? The two pools in this state are tools/cwb_ws_fiab_v7 and toolsalpha/resource_toolsalpha_v8.

@jgainerdewar jgainerdewar requested a review from a team as a code owner November 7, 2024 21:29
@jgainerdewar jgainerdewar requested review from dvoet and kevinmarete and removed request for a team November 7, 2024 21:29
Copy link

sonarcloud bot commented Nov 7, 2024

Copy link

@kevinmarete kevinmarete left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks is order, thanks for cleaning up!

@dvoet
Copy link
Contributor

dvoet commented Nov 8, 2024

I can't find any reference to tools/cwb_ws_fiab_v7, or v8 for that matter. Maybe their use died with FIABs. The comment here says resource_toolsalpha is for local testing. Maybe you want another PR for it, but I think you can drop cwb_ws_fiab all together and drop the old version of resource_toolsalpha

@jgainerdewar jgainerdewar merged commit 3d45e37 into master Nov 8, 2024
5 checks passed
@jgainerdewar jgainerdewar deleted the jd_AN-186_removePools branch November 8, 2024 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants