Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TSPS-328 add optional samples subselection to SubsetVcfByBedFile WDL #138

Merged
merged 11 commits into from
Oct 8, 2024

Conversation

mmorgantaylor
Copy link
Collaborator

@mmorgantaylor mmorgantaylor commented Sep 25, 2024

Description

WDL updates to SubsetVcfByBedFile (masking wdl) to allow subsetting by samples.

Add new WDL: UpdateVcfDictionaryHeader, to update a VCF's headers to include the proper contigs as specified by a reference dictionary.

Jira Ticket

https://broadworkbench.atlassian.net/browse/TSPS-328

@mmorgantaylor mmorgantaylor marked this pull request as ready for review October 7, 2024 16:42
version 1.0

# This script is under review. It is not actively tested or maintained at this time.
workflow UpdateVcfHeaderContigs {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe UpdateVcfDictionaryHeader or UpsertVcfDictionaryHeader

}
}

task UpdateHeader {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same follow through as the other name of the wdl

@jsotobroad
Copy link
Collaborator

jsotobroad commented Oct 8, 2024

oh and can we update the readme with the input change and the new wdl

Copy link

sonarcloud bot commented Oct 8, 2024

Copy link
Collaborator

@jsotobroad jsotobroad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the readme updates!

@mmorgantaylor mmorgantaylor merged commit 110b968 into main Oct 8, 2024
12 checks passed
@mmorgantaylor mmorgantaylor deleted the TSPS-328_mma_update_masking branch October 8, 2024 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants