TSPS-348 part one: Publish Python thin client #148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmorgantaylor
had a problem deploying
to
release
GitHub Actions
Failure
jsotobroad
reviewed
Oct 30, 2024
| -i common/openapi.yml \ | ||
| -g python \ | ||
| -o teaspoons-client \ | ||
| --additional-properties=projectName=terra-scientific-pipelines-service-client,packageName=teaspoons_client,packageVersion=${{ inputs.new-tag || '0.0.0' }},httpUserAgent=terra-scientific-pipeliens-service-client/${{ inputs.new-tag || '0.0.0'}}/python |
There was a problem hiding this comment.
Do we call this terra-scientific-pipelines-service-thin-client or how will we distinguish this Pypi package from the thick client?
.github/workflows/tag-publish.yml
Outdated
| @@ -22,15 +22,23 @@ on: | |||
| push: | |||
There was a problem hiding this comment.
i think you may have forgotten to push the latest changes to this file
jsotobroad
reviewed
Oct 31, 2024
| @@ -169,7 +182,7 @@ jobs: | |||
| uses: ncipollo/release-action@v1 | |||
| id: create_release | |||
| with: | |||
| tag: ${{ steps.tag.outputs.tag }} | |||
There was a problem hiding this comment.
there is another place in this job step where steps.tag.outputs.tag is referenced, do we not need to change that as well?
There was a problem hiding this comment.
oh good call, there were actually several other places that needed to be updated. thank you!
mmorgantaylor
changed the title
jsotobroad
approved these changes
Nov 1, 2024
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Publish the thin (auto-generated) client to PyPi via GHA.
Jira Ticket
achieves part of https://broadworkbench.atlassian.net/browse/TSPS-348