TSPS-325 Support for adding more CLI commands #164
Conversation
| .timeCompleted( | ||
| pipelineRun.getStatus().isCompleted() | ||
| ? pipelineRun.getUpdated().toString() | ||
| : null)) |
There was a problem hiding this comment.
does setting it to null change the default behavior of not being in the response if there is no value? I'm pretty sure it doesnt since its starts out as null but just curious
There was a problem hiding this comment.
this has the same effect as just not setting timeCompleted at all if the run isn't completed. here's what's in the API response:
{
"jobId": "30d0ec3d-06e0-41ef-944a-846704926037",
"status": "RUNNING",
"description": "local test jobmapkeys refactor and hooks, fixed wdl version",
"timeSubmitted": "2024-10-08T13:34:39.289930"
},
do you prefer that we not set it, rather than set it to null? it seems like it might make the logic a little gnarlier since I don't know if you can call a .timeCompleted() inside an if statement?
There was a problem hiding this comment.
nope this is great, i was just double checking the response was the same even though it should have been obvious to me that it was
common/openapi.yml
Outdated
| @@ -733,14 +733,18 @@ components: | |||
| description: | | |||
| Object containing the job id, status, and user-provided description of a Pipeline Run. | |||
There was a problem hiding this comment.
can update this description
There was a problem hiding this comment.
good call thanks!
|
Description
Fix an error in our openapi.yml as well as don't require the description field in the PipelineRun object returned by getAllPipelineRuns. This wasn't actually making the field required anyway in our response - the following is the response to getAllPipelineRuns before this change:
But making it not required allows the autogenerated Python client to accept this response rather than failing it on validation when a description is not present.
Goes with CLI PR: DataBiosphere/terra-scientific-pipelines-service-cli#14
Jira Ticket
in support of https://broadworkbench.atlassian.net/browse/TSPS-325