Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TSPS-97] Update tag-publish workflow to publish container images from PRs #39

Merged
merged 5 commits into from
Nov 13, 2023

Conversation

choover-broad
Copy link
Contributor

@choover-broad choover-broad commented Oct 30, 2023

Update TSPS's tag-publish workflow to publish container images from PRs, and also report them to Sherlock. This will allow TSPS devs to leverage Beehive's "deploy from a PR branch feature".

PR container image versions will consist of the next semver, suffixed with the git commit. (eg. 1.2.3-5e99528).

Testing

I've successfully deployed images from this PR to my BEE (version 0.0.37-143e6b2 was built in [this GHA run]

Screenshot 2023-11-13 at 2 10 35 PM Screenshot 2023-11-13 at 2 04 12 PM

@choover-broad choover-broad changed the title [TSPS-97] Update tag-publish workflow to also publish builds off of PRs [TSPS-97] Update tag-publish workflow to publish container images from PRs Oct 31, 2023
@choover-broad choover-broad marked this pull request as ready for review November 13, 2023 19:04
Copy link
Collaborator

@jsotobroad jsotobroad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Just cuz im curious, is the commit hash added to the image tag in databiosphere/github-actions/actions/[email protected] ? Like it has logic in there to know whether the commit hash should be added or is that happening somewhere else entirely?

Copy link

sonarcloud bot commented Nov 13, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@choover-broad
Copy link
Contributor Author

choover-broad commented Nov 13, 2023

Awesome! Just cuz im curious, is the commit hash added to the image tag in databiosphere/github-actions/actions/[email protected] ? Like it has logic in there to know whether the commit hash should be added or is that happening somewhere else entirely?

@jsotobroad yes! the bumper action basically checks if $current_branch == "main" and if not, appends the hash https://github.com/DataBiosphere/github-actions/blob/master/actions/bumper/entrypoint.sh#L37

@choover-broad choover-broad merged commit 606c777 into main Nov 13, 2023
9 checks passed
@choover-broad choover-broad deleted the ch-TSPS-97 branch November 13, 2023 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants