Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TSPS-100 add logic to use service account credentials when talking to leonardo #42

Merged
merged 11 commits into from
Nov 28, 2023
Merged

TSPS-100 add logic to use service account credentials when talking to leonardo #42

merged 11 commits into from
Nov 28, 2023

Conversation

jsotobroad
Copy link
Collaborator

Description

Changing our usage of the leonardo client to use the google default credentials available instead of user credentials. These can be supplied manually when developing and will be provided as part of the deployment in live environments

Jira Ticket

https://broadworkbench.atlassian.net/browse/TSPS-100

koncheto-broad
koncheto-broad approved these changes Nov 21, 2023
View reviewed changes
Copy link
Collaborator

@koncheto-broad koncheto-broad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not 100% sure what the ImputationService class will ultimately do vs the flights that actually pull together the disparate pieces necessary to use our service end to end, but let's see where this goes!

@jsotobroad
Copy link
Collaborator Author

Not 100% sure what the ImputationService class will ultimately do vs the flights that actually pull together the disparate pieces necessary to use our service end to end, but let's see where this goes!

yup yup for now i was thinking of using ImputationService to pull all the work we've been doing together and then once flights are available figuring out the correct pattern to follow.

@jsotobroad jsotobroad mentioned this pull request Nov 27, 2023
Closed
mmorgantaylor
mmorgantaylor approved these changes Nov 28, 2023
View reviewed changes
Copy link
Collaborator

@mmorgantaylor mmorgantaylor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

super nice! thanks for updating the README and organizing the dependencies.

scripts/write-config.sh Outdated Show resolved Hide resolved
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 28, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

96.4% 96.4% Coverage
0.0% 0.0% Duplication

@jsotobroad jsotobroad merged commit 9f9e8c1 into main Nov 28, 2023
14 checks passed
@jsotobroad jsotobroad deleted the js_TSPS-100 branch November 28, 2023 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@koncheto-broad koncheto-broad koncheto-broad approved these changes

@mmorgantaylor mmorgantaylor mmorgantaylor approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jsotobroad @mmorgantaylor @koncheto-broad