Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update publish image github action slack message #45

Merged
merged 1 commit into from
Nov 30, 2023

Conversation

jsotobroad
Copy link
Collaborator

@jsotobroad jsotobroad commented Nov 29, 2023

Description

Its useful to also have a link to the PR/commit that corresponds to the failed publish action. This is what it looks like now

Before

Screenshot 2023-11-29 at 4 09 08 PM

After
Screenshot 2023-11-29 at 4 09 19 PM

Is it better or worse?

Jira Ticket

N/A

@jsotobroad jsotobroad changed the title test commit Update publish image github action slack message Nov 29, 2023
@jsotobroad jsotobroad force-pushed the js_test_tag_publish_action_failure branch from 358ad57 to 69155d7 Compare November 29, 2023 21:12
@jsotobroad jsotobroad force-pushed the js_test_tag_publish_action_failure branch from 69155d7 to 18da9c4 Compare November 29, 2023 22:33
Copy link

sonarcloud bot commented Nov 29, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link
Collaborator

@mmorgantaylor mmorgantaylor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

woohoo! thanks!

@jsotobroad jsotobroad merged commit 73a7b9c into main Nov 30, 2023
9 checks passed
@jsotobroad jsotobroad deleted the js_test_tag_publish_action_failure branch November 30, 2023 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants