TSPS-150 add tests for JobApiUtils #51
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
jsotobroad
approved these changes
Jan 29, 2024
| FlightStatus.FATAL, TestUtils.TEST_NEW_UUID); | ||
| flightState.setException(new InternalStairwayException("some message")); | ||
|
|
||
| ApiJobReport apiJobReport = JobApiUtils.mapFlightStateToApiJobReport(flightState); |
There was a problem hiding this comment.
huh im kind of surprised the ApiJobReport doesnt report the exception message.
There was a problem hiding this comment.
I was too. the spec defines the JobReport as the response for "get job status", and you have to call "get job result" to get the ErrorReport (that contains the error message and causes). we could consider adding the error message to JobReport, or we could create the "get job result" endpoint such that it can be used for polling, and if you use that one you'll get the ErrorReport. I'd lean toward the latter but we can discuss and make another ticket if needed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added a test class for JobApiUtils, and in the process refactored some commonly used test variables and methods into StairwayTestUtils.
Jira Ticket
https://broadworkbench.atlassian.net/browse/TSPS-150