UIE-204 Narrow Ajax Usage pt12 #5173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msilva-broad
commented
Nov 18, 2024
| partial<UserContract>({ | ||
| getSamUserCombinedState: jest.fn().mockResolvedValue(mockSamUserCombinedState), | ||
| profile: { | ||
| get: jest.fn(async () => partial<TerraUserProfile>({})), |
There was a problem hiding this comment.
this jest.fn inline form gives great type safety, whereas jest.fn().mockResolvedValue(...) has no type safety because of a cast to "any" out of jest.fn().
- shifting ajax usage to directly use ajax sub-areas for the user profile and registration areas. - improving mock types where possible.
- minor typo fix
- improved type safety in mocks for test in TermsOfServicePage.test.ts
msilva-broad
force-pushed
the
msilva/UIE-204_Narrow-ajax-usage_pt12
branch
from
db356c9
to
4c1db8b
Compare
|
calypsomatic
approved these changes
Nov 19, 2024
marctalbott
approved these changes
Nov 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira Ticket: https://broadworkbench.atlassian.net/browse/[Ticket #]
Summary of changes:
What
Why
Testing strategy