Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CORE-132] Autogenerate dataTable from Data Uploader #5174

Merged
merged 6 commits into from
Nov 21, 2024

Conversation

kevinmarete
Copy link
Contributor

@kevinmarete kevinmarete commented Nov 19, 2024

Jira Ticket: https://broadworkbench.atlassian.net/browse/CORE-132

What

  • This PR delivers an MVP for the autogenerate data table feature in the data uploader. Key additions include:
    • Users can choose between uploading a TSV manually or using the autogeneration feature.
    • Users can cancel autogeneration and return to manual upload if needed.
    • API Integration: Connects to the CORE-123 API for generating data tables.
    • Metrics: Tracks usage and acceptance rates of the feature via Mixpanel.

Why

  • This feature simplifies data table creation by auto-matching Illumina files for sequencing, aiming to save time and provide quick user feedback for further improvements.

Testing strategy

  • Manual Testing: Feature Flag: Toggle the feature flag titled "Autogenerate data table for single and paired end sequencing" to access this MVP.
Autogenerate.Table.mov

feedbackUrl: `mailto:[email protected]?subject=${encodeURIComponent(
'Feedback on Autogenerate data table for single and paired end sequencing'
)}`,
lastUpdated: '11/26/2024',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just curious - is this date a guess for when it's going out or what?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it is a guess of when I anticipate this work to get to prod.

Copy link
Contributor

@davidangb davidangb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm sad this doesn't have any tests, but that's a pre-existing state; this PR just maintains that state.

One question about functionality inline, which might need input from Product. Otherwise looks good, and thank you!

setAutoGeneratedFile({
workspaceNamespace: namespace,
workspaceName: name,
entityType: collection,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would it be better to ask the user to specify the table name - perhaps with a suggested default of the collection value - instead of assuming? I fear that the subdirectory into which users upload files is not what they desire for a table name.

Copy link

@admull admull Nov 19, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's ok to keep as currently implemented for preview and something we can get feedback on!

Copy link
Contributor

@davidangb davidangb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If Adam/Product is good with this, then 👍

Copy link

sonarcloud bot commented Nov 20, 2024

@kevinmarete kevinmarete added this pull request to the merge queue Nov 20, 2024
Merged via the queue into dev with commit bc4f4ac Nov 21, 2024
10 checks passed
@kevinmarete kevinmarete deleted the km_CORE-132_uploader_datatable_autogenerate branch November 21, 2024 00:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants