-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CORE-132] Autogenerate dataTable from Data Uploader #5174
Conversation
feedbackUrl: `mailto:[email protected]?subject=${encodeURIComponent( | ||
'Feedback on Autogenerate data table for single and paired end sequencing' | ||
)}`, | ||
lastUpdated: '11/26/2024', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just curious - is this date a guess for when it's going out or what?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, it is a guess of when I anticipate this work to get to prod.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm sad this doesn't have any tests, but that's a pre-existing state; this PR just maintains that state.
One question about functionality inline, which might need input from Product. Otherwise looks good, and thank you!
setAutoGeneratedFile({ | ||
workspaceNamespace: namespace, | ||
workspaceName: name, | ||
entityType: collection, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
would it be better to ask the user to specify the table name - perhaps with a suggested default of the collection
value - instead of assuming? I fear that the subdirectory into which users upload files is not what they desire for a table name.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's ok to keep as currently implemented for preview and something we can get feedback on!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If Adam/Product is good with this, then 👍
Quality Gate passedIssues Measures |
Jira Ticket: https://broadworkbench.atlassian.net/browse/CORE-132
What
Why
Testing strategy
Autogenerate.Table.mov