UIE-204 Narrow Ajax Usage pt13 #5176
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msilva-broad
commented
Nov 21, 2024
| toStorageString: '', | ||
| }; | ||
|
|
||
| Ajax.mockImplementation(() => { |
There was a problem hiding this comment.
This must be a left-over from an earlier version of this test... Ajax.mockImplementation is called a 2nd time just after this, which negates this mock implementation completely. So this block and its referenced bits like mockOidcUser can be removed.
msilva-broad
commented
Nov 21, 2024
| @@ -6,6 +6,8 @@ import { dataCatalogStore } from 'src/libs/state'; | |||
| import { Datasets } from 'src/pages/library/Datasets'; | |||
| import { renderWithAppContexts as render } from 'src/testing/test-utils'; | |||
|
|
|||
| jest.mock('src/libs/ajax/Metrics'); | |||
There was a problem hiding this comment.
mocking Metrics as a precaution
- shifting ajax usage to directly use ajax sub-areas for some of the src/pages uses. - improving mock types where possible.
msilva-broad
force-pushed
the
msilva/UIE-204_Narrow-ajax-usage_pt13
branch
from
71fc0df
to
95a2f28
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira Ticket: https://broadworkbench.atlassian.net/browse/[Ticket #]
Summary of changes:
What
Why
Testing strategy