Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Init mapping ids to serialised nodes #3014

Open
wants to merge 5 commits into
base: najib.boutaib/RUM-6042-POC-error-mode-replay
Choose a base branch
from

Conversation

N-Boutaib
Copy link
Contributor

@N-Boutaib N-Boutaib commented Sep 18, 2024

Motivation

POC of Error mode replay

Changes

Adding squashing logic - copied from web-ui

  • Apply incremental mutation on FS
  • Update Meta, Focus and VisualViewport records
  • Batch StyleSheetRules
  • Batch MediaInteraction
  • Discard all other records
  • TODO: Handle element focus and hover from mouse interactions

Using Squashing logic

  • Periodically squash records, every 30 seconds
  • Squash records before flushing cache into segments (when replay is forced)

Cache clearing

  • On view end, clear the cache
  • After records are batched into segment, clear cache

Testing

  • Local
  • Staging
  • Unit
  • End to end

I have gone over the contributing documentation.

@N-Boutaib N-Boutaib force-pushed the najib.boutaib/RUM-6110-add-squashing-logic-to-sdk branch from dd78072 to 243b4b7 Compare September 27, 2024 14:41
@N-Boutaib N-Boutaib changed the base branch from main to najib.boutaib/RUM-6042-POC-error-mode-replay September 27, 2024 14:41
Copy link

cit-pr-commenter bot commented Sep 30, 2024

Bundles Sizes Evolution

📦 Bundle Name Base Size Local Size 𝚫 𝚫% Status
Rum 0 B 167.00 KiB 167.00 KiB N/A%
Logs 56.03 KiB 56.03 KiB 0 B 0.00%
Rum Slim 110.52 KiB 110.52 KiB 0 B 0.00%
Worker 25.21 KiB 25.21 KiB 0 B 0.00%
🚀 CPU Performance
Action Name Base Average Cpu Time (ms) Local Average Cpu Time (ms) 𝚫
addglobalcontext 0.001 0.001 0.000
addaction 0.030 0.031 0.001
addtiming 0.001 0.001 -0.000
adderror 0.029 0.031 0.002
startstopsessionreplayrecording 0.751 0.822 0.071
startview 0.928 0.977 0.048
logmessage 0.018 0.018 -0.000
🧠 Memory Performance
Action Name Base Consumption Memory (bytes) Local Consumption Memory (bytes) 𝚫 (bytes)
addglobalcontext 10.90 KiB 11.29 KiB 403 B
addaction 41.32 KiB 39.90 KiB -1456 B
addtiming 10.15 KiB 10.24 KiB 91 B
adderror 46.45 KiB 48.25 KiB 1.80 KiB
startstopsessionreplayrecording 32.17 KiB 573.26 KiB 541.08 KiB
startview 588.05 KiB 447.38 KiB -144039 B
logmessage 42.28 KiB 43.97 KiB 1.69 KiB

🔗 RealWorld

@N-Boutaib N-Boutaib marked this pull request as ready for review September 30, 2024 09:14
@N-Boutaib N-Boutaib requested a review from a team as a code owner September 30, 2024 09:14
Copy link
Member

@BenoitZugmeyer BenoitZugmeyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR significantly increase the bundle size, please don't merge too quickly, I need some time to think about it

@N-Boutaib
Copy link
Contributor Author

This PR significantly increase the bundle size, please don't merge too quickly, I need some time to think about it

Indeed. In any case, I was planing to merge it into the the POC branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants