Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop RUM event publishing on unload instead of beforeUnload #3033

Closed
wants to merge 3 commits into from

Conversation

sukhpreet96
Copy link

@sukhpreet96 sukhpreet96 commented Sep 23, 2024

Motivation

To fix the issues with beforeUnload event.

Changes

Changed stopping of RUM events from beforeUnload to unload

Testing

  • Local
  • Staging
  • Unit
  • End to end

I have gone over the contributing documentation.

@sukhpreet96 sukhpreet96 requested a review from a team as a code owner September 23, 2024 17:58
@sukhpreet96 sukhpreet96 changed the title Unload fix Stop RUM event publishing on unload instead of beforeUnload Sep 23, 2024
Copy link
Member

@BenoitZugmeyer BenoitZugmeyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While we are aware of beforeunload shortcomings, we don't intend to change the current strategy at this point, as it would impact reliability. It is still on our mind though, and we might do something about it in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants