Skip to content

Commit

Permalink
[EBPF] gpu: use flaky.MarkOnLog on e2e test (#33524)
Browse files Browse the repository at this point in the history
  • Loading branch information
gjulianm authored Jan 30, 2025
1 parent 7ead26c commit 6115a6c
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 16 deletions.
5 changes: 3 additions & 2 deletions test/new-e2e/tests/gpu/gpu_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -53,8 +53,9 @@ func mandatoryMetricTagRegexes() []*regexp.Regexp {
// TestGPUSuite runs tests for the VM interface to ensure its implementation is correct.
// Not to be run in parallel, as some tests wait until the checks are available.
func TestGPUSuite(t *testing.T) {
// incident-33572
flake.Mark(t)
// incident-33572. Pulumi seems to sometimes fail to create the stack with an error
// we are not able to debug from the logs. We mark the test as flaky in that case only.
flake.MarkOnLog(t, "error: an unhandled error occurred: waiting for RPCs:")
provParams := getDefaultProvisionerParams()

// Append our vectorAdd image for testing
Expand Down
14 changes: 0 additions & 14 deletions test/new-e2e/tests/gpu/provisioner.go
Original file line number Diff line number Diff line change
Expand Up @@ -142,20 +142,6 @@ func gpuInstanceProvisioner(params *provisionerParams) provisioners.Provisioner
if err != nil {
return fmt.Errorf("validateDockerCuda failed: %w", err)
}
// incident-33572: log the output of the CUDA validation command
pulumi.All(dockerCudaValidateCmd.StdoutOutput(), dockerCudaValidateCmd.StderrOutput()).ApplyT(func(args []interface{}) error {
stdout := args[0].(string)
stderr := args[1].(string)
err := ctx.Log.Info(fmt.Sprintf("Docker CUDA validation stdout: %s", stdout), nil)
if err != nil {
return err
}
err = ctx.Log.Info(fmt.Sprintf("Docker CUDA validation stderr: %s", stderr), nil)
if err != nil {
return err
}
return nil
})

// Combine agent options from the parameters with the fakeintake and docker dependencies
params.agentOptions = append(params.agentOptions,
Expand Down

0 comments on commit 6115a6c

Please sign in to comment.