Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FA][HA Agent][NDMII-3267] Add config_id metadata #33215

Merged
merged 12 commits into from
Jan 30, 2025

Conversation

AlexandreYang
Copy link
Member

@AlexandreYang AlexandreYang commented Jan 22, 2025

What does this PR do?

[FA]HA Agent Add config_id, ha_agent_enabled, ha_agent_state metadata

Motivation

Motivation: New fields needed for Fleet Automation and HA Agent feature

  • config_id: Need for Fleet Automation
  • ha_agent_enabled: this is needed to know when to show or not some HA related elements in UI
  • ha_agent_state: this is needed to show the Agent State

Describe how you validated your changes

Possible Drawbacks / Trade-offs

Additional Notes

@github-actions github-actions bot added short review PR is simple enough to be reviewed quickly [deprecated] team/agent-shared-components Deprecated. Use team/agent-configuration or team/agent-runtimes labels instead. labels Jan 22, 2025
@AlexandreYang AlexandreYang changed the title [DRAFT][HA Agent] Add ha_agent_state metadata [DRAFT][HA Agent][NDMII-3267] Add ha_agent_state metadata Jan 22, 2025
@agent-platform-auto-pr
Copy link
Contributor

agent-platform-auto-pr bot commented Jan 22, 2025

Uncompressed package size comparison

Comparison with ancestor 0b1e55627c4476098c3015c8afef5ee0598b3dad

Diff per package
package diff status size ancestor threshold
datadog-dogstatsd-arm64-deb 0.00MB 56.50MB 56.50MB 0.50MB
datadog-iot-agent-arm64-deb 0.00MB 89.87MB 89.87MB 0.50MB
datadog-iot-agent-aarch64-rpm 0.00MB 89.94MB 89.94MB 0.50MB
datadog-iot-agent-x86_64-rpm 0.00MB 93.87MB 93.87MB 0.50MB
datadog-iot-agent-x86_64-suse 0.00MB 93.87MB 93.87MB 0.50MB
datadog-dogstatsd-x86_64-rpm 0.00MB 59.09MB 59.09MB 0.50MB
datadog-dogstatsd-x86_64-suse 0.00MB 59.09MB 59.09MB 0.50MB
datadog-agent-amd64-deb 0.00MB 911.86MB 911.86MB 0.50MB
datadog-agent-x86_64-rpm 0.00MB 921.60MB 921.60MB 0.50MB
datadog-agent-x86_64-suse 0.00MB 921.60MB 921.60MB 0.50MB
datadog-agent-arm64-deb 0.00MB 899.25MB 899.25MB 0.50MB
datadog-agent-aarch64-rpm 0.00MB 908.97MB 908.97MB 0.50MB
datadog-dogstatsd-amd64-deb 0.00MB 59.01MB 59.01MB 0.50MB
datadog-heroku-agent-amd64-deb 0.00MB 477.81MB 477.81MB 0.50MB
datadog-iot-agent-amd64-deb 0.00MB 93.80MB 93.80MB 0.50MB

Decision

✅ Passed

@agent-platform-auto-pr
Copy link
Contributor

agent-platform-auto-pr bot commented Jan 22, 2025

Test changes on VM

Use this command from test-infra-definitions to manually test this PR changes on a VM:

inv aws.create-vm --pipeline-id=54326045 --os-family=ubuntu

Note: This applies to commit 359607d

Copy link

cit-pr-commenter bot commented Jan 22, 2025

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: 28a4a94d-42a2-4395-af45-8173182a8ffa

Baseline: 0b1e556
Comparison: 359607d
Diff

Optimization Goals: ✅ No significant changes detected

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
uds_dogstatsd_to_api_cpu % cpu utilization +3.13 [+2.20, +4.05] 1 Logs
tcp_syslog_to_blackhole ingress throughput +2.11 [+2.05, +2.18] 1 Logs
quality_gate_idle memory utilization +0.51 [+0.47, +0.55] 1 Logs bounds checks dashboard
file_tree memory utilization +0.39 [+0.33, +0.45] 1 Logs
file_to_blackhole_100ms_latency egress throughput +0.05 [-0.76, +0.87] 1 Logs
file_to_blackhole_0ms_latency egress throughput +0.04 [-0.88, +0.96] 1 Logs
file_to_blackhole_0ms_latency_http1 egress throughput +0.03 [-0.91, +0.96] 1 Logs
file_to_blackhole_300ms_latency egress throughput +0.02 [-0.61, +0.66] 1 Logs
tcp_dd_logs_filter_exclude ingress throughput -0.00 [-0.02, +0.02] 1 Logs
uds_dogstatsd_to_api ingress throughput -0.01 [-0.30, +0.27] 1 Logs
file_to_blackhole_0ms_latency_http2 egress throughput -0.03 [-0.94, +0.88] 1 Logs
quality_gate_idle_all_features memory utilization -0.04 [-0.09, +0.01] 1 Logs bounds checks dashboard
file_to_blackhole_500ms_latency egress throughput -0.12 [-0.92, +0.67] 1 Logs
file_to_blackhole_1000ms_latency egress throughput -0.35 [-1.12, +0.43] 1 Logs
file_to_blackhole_1000ms_latency_linear_load egress throughput -0.42 [-0.88, +0.04] 1 Logs
quality_gate_logs % cpu utilization -3.47 [-6.46, -0.48] 1 Logs

Bounds Checks: ✅ Passed

perf experiment bounds_check_name replicates_passed links
file_to_blackhole_0ms_latency lost_bytes 10/10
file_to_blackhole_0ms_latency memory_usage 10/10
file_to_blackhole_0ms_latency_http1 lost_bytes 10/10
file_to_blackhole_0ms_latency_http1 memory_usage 10/10
file_to_blackhole_0ms_latency_http2 lost_bytes 10/10
file_to_blackhole_0ms_latency_http2 memory_usage 10/10
file_to_blackhole_1000ms_latency memory_usage 10/10
file_to_blackhole_1000ms_latency_linear_load memory_usage 10/10
file_to_blackhole_100ms_latency lost_bytes 10/10
file_to_blackhole_100ms_latency memory_usage 10/10
file_to_blackhole_300ms_latency lost_bytes 10/10
file_to_blackhole_300ms_latency memory_usage 10/10
file_to_blackhole_500ms_latency lost_bytes 10/10
file_to_blackhole_500ms_latency memory_usage 10/10
quality_gate_idle intake_connections 10/10 bounds checks dashboard
quality_gate_idle memory_usage 10/10 bounds checks dashboard
quality_gate_idle_all_features intake_connections 10/10 bounds checks dashboard
quality_gate_idle_all_features memory_usage 10/10 bounds checks dashboard
quality_gate_logs intake_connections 10/10
quality_gate_logs lost_bytes 10/10
quality_gate_logs memory_usage 10/10

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

Passed. All Quality Gates passed.

  • quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.

@github-actions github-actions bot added medium review PR review might take time and removed short review PR is simple enough to be reviewed quickly labels Jan 27, 2025
@AlexandreYang AlexandreYang changed the title [DRAFT][HA Agent][NDMII-3267] Add ha_agent_state metadata [HA Agent][NDMII-3267] Add ha_agent_state metadata Jan 27, 2025
@AlexandreYang AlexandreYang marked this pull request as ready for review January 27, 2025 12:59
@AlexandreYang AlexandreYang requested review from a team as code owners January 27, 2025 12:59
@AlexandreYang AlexandreYang changed the title [HA Agent][NDMII-3267] Add ha_agent_state metadata [HA Agent][NDMII-3267] Add config_id, ha_agent_enabled, ha_agent_state metadata Jan 27, 2025
@AlexandreYang AlexandreYang changed the title [HA Agent][NDMII-3267] Add config_id, ha_agent_enabled, ha_agent_state metadata [FA][HA Agent][NDMII-3267] Add config_id, ha_agent_enabled, ha_agent_state metadata Jan 27, 2025
@AlexandreYang AlexandreYang added the qa/done QA done before merge and regressions are covered by tests label Jan 27, 2025
@AlexandreYang AlexandreYang added this to the 7.64.0 milestone Jan 27, 2025

func (ia *inventoryagent) fetchHaAgentMetadata() {
ia.data["ha_agent_enabled"] = ia.haAgent.Enabled()
ia.data["ha_agent_state"] = ia.haAgent.GetState()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will this state change often ? We want very static data in REDAPL (storage used for this payload).
Also, should we trigger a new payload each time ha state changes or is it OK to wait for the next payload interval ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hush-hush

Will this state change often ? We want very static data in REDAPL (storage used for this payload).

The state field can indeed change, but it changes very rarely. Example: in HA setup, we have agent1 (state:active) and agent2 (state:standby), agent2 might change its state to active, but only when agent1 is down/crashes.

Also, customer that will use the HA Agent feature will be very limited (likely only large customers that are willing to run 2 agents in active/standby to get fault tolerance).

I think it shouldn't create additional actual writes to REDAPL, since the change frequency is very low, and only few customers will use HA.

Also, should we trigger a new payload each time ha state changes or is it OK to wait for the next payload interval ?

If should be OK for this case, we can wait for next payload interval. The REDAPL backend guarantee is 5min anyway :)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We resend payload to REDAPL every 10min if we don't get any updates. And this interval might be expanded at some point to lower the load on our backend services.

@AlexandreYang AlexandreYang requested a review from jedupau January 28, 2025 08:47
Copy link
Member

@hush-hush hush-hush left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added one last comment about the README. Feel free to merge after that 👍

comp/metadata/inventoryagent/README.md Outdated Show resolved Hide resolved
comp/haagent/impl/haagent_testutils_test.go Outdated Show resolved Hide resolved
comp/haagent/impl/haagent.go Outdated Show resolved Hide resolved
@AlexandreYang AlexandreYang requested a review from a team as a code owner January 29, 2025 14:53
@AlexandreYang AlexandreYang removed request for a team January 29, 2025 14:55
@AlexandreYang AlexandreYang changed the title [FA][HA Agent][NDMII-3267] Add config_id, ha_agent_enabled, ha_agent_state metadata [FA][HA Agent][NDMII-3267] Add config_id metadata Jan 29, 2025
@github-actions github-actions bot added long review PR is complex, plan time to review it and removed medium review PR review might take time labels Jan 29, 2025
@AlexandreYang
Copy link
Member Author

/merge

@dd-devflow
Copy link

dd-devflow bot commented Jan 30, 2025

Devflow running: /merge

View all feedbacks in Devflow UI.


2025-01-30 10:22:31 UTC ℹ️ MergeQueue: pull request added to the queue

The median merge time in main is 26m.


2025-01-30 10:48:52 UTC ℹ️ MergeQueue: This merge request was merged

@dd-mergequeue dd-mergequeue bot merged commit 70b588e into main Jan 30, 2025
225 checks passed
@dd-mergequeue dd-mergequeue bot deleted the alex/ha_agent_state_metadata branch January 30, 2025 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog [deprecated] team/agent-shared-components Deprecated. Use team/agent-configuration or team/agent-runtimes labels instead. long review PR is complex, plan time to review it qa/done QA done before merge and regressions are covered by tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants