-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ASCII-2691] Change wording on FIPS Mode status indication #33507
[ASCII-2691] Change wording on FIPS Mode status indication #33507
Conversation
Uncompressed package size comparisonComparison with ancestor Diff per package
Decision✅ Passed |
Test changes on VMUse this command from test-infra-definitions to manually test this PR changes on a VM: inv aws.create-vm --pipeline-id=54330467 --os-family=ubuntu Note: This applies to commit 698c4db |
Regression DetectorRegression Detector ResultsMetrics dashboard Baseline: d51bfeb Optimization Goals: ✅ No significant changes detected
|
perf | experiment | goal | Δ mean % | Δ mean % CI | trials | links |
---|---|---|---|---|---|---|
➖ | quality_gate_logs | % cpu utilization | +1.78 | [-1.30, +4.86] | 1 | Logs |
➖ | tcp_syslog_to_blackhole | ingress throughput | +0.76 | [+0.69, +0.82] | 1 | Logs |
➖ | file_to_blackhole_1000ms_latency | egress throughput | +0.71 | [-0.08, +1.50] | 1 | Logs |
➖ | file_tree | memory utilization | +0.34 | [+0.27, +0.41] | 1 | Logs |
➖ | file_to_blackhole_1000ms_latency_linear_load | egress throughput | +0.15 | [-0.32, +0.62] | 1 | Logs |
➖ | uds_dogstatsd_to_api | ingress throughput | +0.03 | [-0.25, +0.31] | 1 | Logs |
➖ | file_to_blackhole_0ms_latency_http2 | egress throughput | +0.01 | [-0.83, +0.86] | 1 | Logs |
➖ | file_to_blackhole_0ms_latency | egress throughput | +0.01 | [-0.87, +0.89] | 1 | Logs |
➖ | tcp_dd_logs_filter_exclude | ingress throughput | +0.00 | [-0.01, +0.02] | 1 | Logs |
➖ | file_to_blackhole_300ms_latency | egress throughput | -0.00 | [-0.64, +0.63] | 1 | Logs |
➖ | file_to_blackhole_100ms_latency | egress throughput | -0.01 | [-0.78, +0.75] | 1 | Logs |
➖ | file_to_blackhole_500ms_latency | egress throughput | -0.04 | [-0.82, +0.74] | 1 | Logs |
➖ | file_to_blackhole_0ms_latency_http1 | egress throughput | -0.07 | [-0.99, +0.85] | 1 | Logs |
➖ | uds_dogstatsd_to_api_cpu | % cpu utilization | -0.26 | [-1.15, +0.64] | 1 | Logs |
➖ | quality_gate_idle_all_features | memory utilization | -0.28 | [-0.34, -0.22] | 1 | Logs bounds checks dashboard |
➖ | quality_gate_idle | memory utilization | -0.32 | [-0.38, -0.26] | 1 | Logs bounds checks dashboard |
Bounds Checks: ✅ Passed
perf | experiment | bounds_check_name | replicates_passed | links |
---|---|---|---|---|
✅ | file_to_blackhole_0ms_latency | lost_bytes | 10/10 | |
✅ | file_to_blackhole_0ms_latency | memory_usage | 10/10 | |
✅ | file_to_blackhole_0ms_latency_http1 | lost_bytes | 10/10 | |
✅ | file_to_blackhole_0ms_latency_http1 | memory_usage | 10/10 | |
✅ | file_to_blackhole_0ms_latency_http2 | lost_bytes | 10/10 | |
✅ | file_to_blackhole_0ms_latency_http2 | memory_usage | 10/10 | |
✅ | file_to_blackhole_1000ms_latency | memory_usage | 10/10 | |
✅ | file_to_blackhole_1000ms_latency_linear_load | memory_usage | 10/10 | |
✅ | file_to_blackhole_100ms_latency | lost_bytes | 10/10 | |
✅ | file_to_blackhole_100ms_latency | memory_usage | 10/10 | |
✅ | file_to_blackhole_300ms_latency | lost_bytes | 10/10 | |
✅ | file_to_blackhole_300ms_latency | memory_usage | 10/10 | |
✅ | file_to_blackhole_500ms_latency | lost_bytes | 10/10 | |
✅ | file_to_blackhole_500ms_latency | memory_usage | 10/10 | |
✅ | quality_gate_idle | intake_connections | 10/10 | bounds checks dashboard |
✅ | quality_gate_idle | memory_usage | 10/10 | bounds checks dashboard |
✅ | quality_gate_idle_all_features | intake_connections | 10/10 | bounds checks dashboard |
✅ | quality_gate_idle_all_features | memory_usage | 10/10 | bounds checks dashboard |
✅ | quality_gate_logs | intake_connections | 10/10 | |
✅ | quality_gate_logs | lost_bytes | 10/10 | |
✅ | quality_gate_logs | memory_usage | 10/10 |
Explanation
Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%
Performance changes are noted in the perf column of each table:
- ✅ = significantly better comparison variant performance
- ❌ = significantly worse comparison variant performance
- ➖ = no significant change in performance
A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".
For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:
-
Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.
-
Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.
-
Its configuration does not mark it "erratic".
CI Pass/Fail Decision
✅ Passed. All Quality Gates passed.
- quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
- quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
- quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
- quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
) | ||
|
||
// Status returns a displayable string or error of FIPS compliance state of the agent build and runtime | ||
// Status returns a displayable string or error of FIPS Mode of the agent build and runtime | ||
func Status() string { | ||
enabled, _ := Enabled() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❓ question: Why do Enabled
function returned error
if we don't checks it ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The windows "FIPS Mode" has more error modes due to the OS registry look up but they did not want to log it or display that to the user at this point. It is _ in case we want to log it in the future or other users of the fips.Enabled()
interface need to surface it.
func populateFIPSStatus(config config.Component) string { | ||
fipsStatus := fips.Status() | ||
if fipsStatus == "not available" && config.GetString("fips.enabled") == "true" { | ||
return "proxy" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❓ question: Does the Agent use necessarily FIPS proxy if fips.enabled: true
? Can it be bypass by anything else ?
/merge |
Devflow running:
|
(cherry picked from commit 517df3f)
What does this PR do?
This PR modifies the wording added in #33287 and supports a status indicator for the normal
datadog-agent
build re: FIPS Mode and if it is running in proxy status.datadog-agent without the fips-proxy configured:
![regular agent](https://private-user-images.githubusercontent.com/16483405/407520537-f111cd3b-8e88-426b-a5ae-2e2cb74c5ca8.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzkxMzM2MzgsIm5iZiI6MTczOTEzMzMzOCwicGF0aCI6Ii8xNjQ4MzQwNS80MDc1MjA1MzctZjExMWNkM2ItOGU4OC00MjZiLWE1YWUtMmUyY2I3NGM1Y2E4LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMDklMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjA5VDIwMzUzOFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWM1ODc2MmM1MzY5MWRmNDBkZjcwZDQxNjRjNzUyYmIzOTEzN2MzMWY2MWY2YTE3NTYyZTVlOGEyZWQ4ZTUyZWMmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.eQHBt5PnVmWeFUf_t9Q61WhQbtnYDAYayHzEOF7_FIY)
datadog-agent with the fips-proxy configured:
![regular agent fips-proxy](https://private-user-images.githubusercontent.com/16483405/407520560-cb9aab09-1592-4ead-b105-8aadf3bf3848.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzkxMzM2MzgsIm5iZiI6MTczOTEzMzMzOCwicGF0aCI6Ii8xNjQ4MzQwNS80MDc1MjA1NjAtY2I5YWFiMDktMTU5Mi00ZWFkLWIxMDUtOGFhZGYzYmYzODQ4LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMDklMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjA5VDIwMzUzOFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWI4MmUzNDgwMDdmYzA4ODcwY2E2Zjg0OThiNDQ2MmRkNGU2MGExN2FhNzBlNjNmYjEyNzMwNzlmMjMxNjFlMTkmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.JgrlD6F4UWk7fUtBTXorWchkAPf-rUasdkHb7EaeKAA)
datadog-fips-agent without GOFIPS set:
![fips agent GOFIPS=0](https://private-user-images.githubusercontent.com/16483405/407520589-8b8fbc4a-724a-4d44-a6bd-430f17ed92d9.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzkxMzM2MzgsIm5iZiI6MTczOTEzMzMzOCwicGF0aCI6Ii8xNjQ4MzQwNS80MDc1MjA1ODktOGI4ZmJjNGEtNzI0YS00ZDQ0LWE2YmQtNDMwZjE3ZWQ5MmQ5LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMDklMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjA5VDIwMzUzOFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTFmMmNmNWQ1YzlkMjZiZjVmYzM3N2NhN2M4Y2RjZTkwODE4OGRlMWM5YTU5MjE4MzJlZTNmYmNjZjM4Mzc1NzAmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.pg2V9GF2kCAFX2K1y4G8FQ_cZHlzfJA-1Tu4TKPmBa8)
datadog-fips-agent with GOFIPS set:
![datadog-fips-agent](https://private-user-images.githubusercontent.com/16483405/407520624-d3b90a0f-8295-403a-b1a9-4a528ab667b2.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzkxMzM2MzgsIm5iZiI6MTczOTEzMzMzOCwicGF0aCI6Ii8xNjQ4MzQwNS80MDc1MjA2MjQtZDNiOTBhMGYtODI5NS00MDNhLWIxYTktNGE1MjhhYjY2N2IyLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMDklMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjA5VDIwMzUzOFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTAxMTY3NTdlN2VjYWEyYWU1ZWIzODBjODE5NmNhNzExZTRmMGU2ZWFlOWU5MWRiMTIwYTZkNzZjNGRjYTM5ZjkmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.Vf12cXQ4Crg1ZOYKzZQrhFFLdDmiIb338iOGk3n11wo)
Motivation
Describe how you validated your changes
datadog-agent
configurationsPossible Drawbacks / Trade-offs
Additional Notes