Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EBPF] gpu: use flaky.MarkOnLog on e2e test #33524

Merged
merged 2 commits into from
Jan 30, 2025
Merged

[EBPF] gpu: use flaky.MarkOnLog on e2e test #33524

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c270062
Mark flaky on log
gjulianm Jan 29, 2025
8bafd4e
Remove redundant output
gjulianm Jan 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions test/new-e2e/tests/gpu/gpu_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,8 +53,9 @@ func mandatoryMetricTagRegexes() []*regexp.Regexp {
// TestGPUSuite runs tests for the VM interface to ensure its implementation is correct.
// Not to be run in parallel, as some tests wait until the checks are available.
func TestGPUSuite(t *testing.T) {
// incident-33572
flake.Mark(t)
// incident-33572. Pulumi seems to sometimes fail to create the stack with an error
// we are not able to debug from the logs. We mark the test as flaky in that case only.
flake.MarkOnLog(t, "error: an unhandled error occurred: waiting for RPCs:")
provParams := getDefaultProvisionerParams()

// Append our vectorAdd image for testing
Expand Down
14 changes: 0 additions & 14 deletions test/new-e2e/tests/gpu/provisioner.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,20 +142,6 @@ func gpuInstanceProvisioner(params *provisionerParams) provisioners.Provisioner
if err != nil {
return fmt.Errorf("validateDockerCuda failed: %w", err)
}
// incident-33572: log the output of the CUDA validation command
pulumi.All(dockerCudaValidateCmd.StdoutOutput(), dockerCudaValidateCmd.StderrOutput()).ApplyT(func(args []interface{}) error {
stdout := args[0].(string)
stderr := args[1].(string)
err := ctx.Log.Info(fmt.Sprintf("Docker CUDA validation stdout: %s", stdout), nil)
if err != nil {
return err
}
err = ctx.Log.Info(fmt.Sprintf("Docker CUDA validation stderr: %s", stderr), nil)
if err != nil {
return err
}
return nil
})

// Combine agent options from the parameters with the fakeintake and docker dependencies
params.agentOptions = append(params.agentOptions,
Expand Down
Loading