Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Move DCA changelogs #33537

Merged
merged 2 commits into from
Jan 29, 2025
Merged

fix: Move DCA changelogs #33537

merged 2 commits into from
Jan 29, 2025

Conversation

gabedos
Copy link
Contributor

@gabedos gabedos commented Jan 29, 2025

What does this PR do?

Move DCA specific changelogs out from regular Agent changelogs and into the proper directory.

Motivation

Proper changelogs to release agent v7.62.0

Describe how you validated your changes

N/A

Possible Drawbacks / Trade-offs

N/A

Additional Notes

N/A

@gabedos gabedos added the qa/no-code-change No code change in Agent code requiring validation label Jan 29, 2025
@gabedos gabedos requested a review from a team as a code owner January 29, 2025 14:26
@github-actions github-actions bot added the short review PR is simple enough to be reviewed quickly label Jan 29, 2025
@agent-platform-auto-pr
Copy link
Contributor

agent-platform-auto-pr bot commented Jan 29, 2025

[Fast Unit Tests Report]

On pipeline 54354145 (CI Visibility). The following jobs did not run any unit tests:

Jobs:
  • tests_deb-arm64-py3
  • tests_deb-x64-py3
  • tests_flavor_dogstatsd_deb-x64
  • tests_flavor_heroku_deb-x64
  • tests_flavor_iot_deb-x64
  • tests_rpm-arm64-py3
  • tests_rpm-x64-py3
  • tests_windows-x64

If you modified Go files and expected unit tests to run in these jobs, please double check the job logs. If you think tests should have been executed reach out to #agent-devx-help

@agent-platform-auto-pr
Copy link
Contributor

agent-platform-auto-pr bot commented Jan 29, 2025

Uncompressed package size comparison

Comparison with ancestor f562fb568001fc82117bb6f561d73bca32a45465

Diff per package
package diff status size ancestor threshold
datadog-agent-x86_64-rpm 0.00MB 921.32MB 921.32MB 0.50MB
datadog-agent-x86_64-suse 0.00MB 921.32MB 921.32MB 0.50MB
datadog-agent-amd64-deb 0.00MB 911.58MB 911.58MB 0.50MB
datadog-dogstatsd-amd64-deb 0.00MB 59.01MB 59.01MB 0.50MB
datadog-dogstatsd-x86_64-rpm 0.00MB 59.09MB 59.09MB 0.50MB
datadog-dogstatsd-x86_64-suse 0.00MB 59.09MB 59.09MB 0.50MB
datadog-dogstatsd-arm64-deb 0.00MB 56.50MB 56.50MB 0.50MB
datadog-heroku-agent-amd64-deb 0.00MB 477.89MB 477.89MB 0.50MB
datadog-iot-agent-amd64-deb 0.00MB 93.88MB 93.88MB 0.50MB
datadog-iot-agent-x86_64-rpm 0.00MB 93.95MB 93.95MB 0.50MB
datadog-iot-agent-x86_64-suse 0.00MB 93.95MB 93.95MB 0.50MB
datadog-iot-agent-arm64-deb 0.00MB 89.93MB 89.93MB 0.50MB
datadog-iot-agent-aarch64-rpm 0.00MB 90.00MB 90.00MB 0.50MB
datadog-agent-aarch64-rpm -0.00MB 908.69MB 908.70MB 0.50MB
datadog-agent-arm64-deb -0.00MB 898.97MB 898.98MB 0.50MB

Decision

✅ Passed

@gabedos gabedos added the backport/7.62.x Automatically create a backport PR to 7.62.x label Jan 29, 2025
Copy link

cit-pr-commenter bot commented Jan 29, 2025

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: 679045eb-e185-4211-938e-fddd46cd2600

Baseline: f562fb5
Comparison: 95d3e59
Diff

Optimization Goals: ✅ No significant changes detected

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
quality_gate_logs % cpu utilization +1.67 [-1.40, +4.74] 1 Logs
tcp_syslog_to_blackhole ingress throughput +0.69 [+0.63, +0.76] 1 Logs
file_to_blackhole_1000ms_latency egress throughput +0.56 [-0.24, +1.36] 1 Logs
quality_gate_idle memory utilization +0.50 [+0.46, +0.54] 1 Logs bounds checks dashboard
file_tree memory utilization +0.30 [+0.24, +0.37] 1 Logs
file_to_blackhole_0ms_latency_http1 egress throughput +0.07 [-0.88, +1.03] 1 Logs
file_to_blackhole_0ms_latency egress throughput +0.07 [-0.91, +1.05] 1 Logs
file_to_blackhole_500ms_latency egress throughput +0.05 [-0.72, +0.83] 1 Logs
file_to_blackhole_0ms_latency_http2 egress throughput +0.04 [-0.85, +0.92] 1 Logs
file_to_blackhole_300ms_latency egress throughput +0.02 [-0.61, +0.66] 1 Logs
tcp_dd_logs_filter_exclude ingress throughput +0.00 [-0.02, +0.03] 1 Logs
uds_dogstatsd_to_api ingress throughput -0.01 [-0.31, +0.29] 1 Logs
file_to_blackhole_100ms_latency egress throughput -0.02 [-0.79, +0.75] 1 Logs
file_to_blackhole_1000ms_latency_linear_load egress throughput -0.15 [-0.61, +0.32] 1 Logs
uds_dogstatsd_to_api_cpu % cpu utilization -0.32 [-1.23, +0.59] 1 Logs
quality_gate_idle_all_features memory utilization -0.53 [-0.59, -0.47] 1 Logs bounds checks dashboard

Bounds Checks: ❌ Failed

perf experiment bounds_check_name replicates_passed links
file_to_blackhole_300ms_latency lost_bytes 9/10
file_to_blackhole_0ms_latency lost_bytes 10/10
file_to_blackhole_0ms_latency memory_usage 10/10
file_to_blackhole_0ms_latency_http1 lost_bytes 10/10
file_to_blackhole_0ms_latency_http1 memory_usage 10/10
file_to_blackhole_0ms_latency_http2 lost_bytes 10/10
file_to_blackhole_0ms_latency_http2 memory_usage 10/10
file_to_blackhole_1000ms_latency memory_usage 10/10
file_to_blackhole_1000ms_latency_linear_load memory_usage 10/10
file_to_blackhole_100ms_latency lost_bytes 10/10
file_to_blackhole_100ms_latency memory_usage 10/10
file_to_blackhole_300ms_latency memory_usage 10/10
file_to_blackhole_500ms_latency lost_bytes 10/10
file_to_blackhole_500ms_latency memory_usage 10/10
quality_gate_idle intake_connections 10/10 bounds checks dashboard
quality_gate_idle memory_usage 10/10 bounds checks dashboard
quality_gate_idle_all_features intake_connections 10/10 bounds checks dashboard
quality_gate_idle_all_features memory_usage 10/10 bounds checks dashboard
quality_gate_logs intake_connections 10/10
quality_gate_logs lost_bytes 10/10
quality_gate_logs memory_usage 10/10

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

Passed. All Quality Gates passed.

  • quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.

@gabedos
Copy link
Contributor Author

gabedos commented Jan 29, 2025

/merge

@dd-devflow
Copy link

dd-devflow bot commented Jan 29, 2025

Devflow running: /merge

View all feedbacks in Devflow UI.


2025-01-29 17:48:59 UTC ℹ️ MergeQueue: waiting for PR to be ready

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.


2025-01-29 18:58:13 UTC ℹ️ MergeQueue: merge request added to the queue

The median merge time in main is 27m.


2025-01-29 19:22:25 UTC ℹ️ MergeQueue: This merge request was merged

@dd-mergequeue dd-mergequeue bot merged commit 62c6691 into main Jan 29, 2025
213 checks passed
@dd-mergequeue dd-mergequeue bot deleted the gabedos/fix-changelogs branch January 29, 2025 19:22
@github-actions github-actions bot added this to the 7.64.0 milestone Jan 29, 2025
agent-platform-auto-pr bot pushed a commit that referenced this pull request Jan 29, 2025
Co-authored-by: Ursula Chen <[email protected]>
(cherry picked from commit 62c6691)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport/7.62.x Automatically create a backport PR to 7.62.x qa/no-code-change No code change in Agent code requiring validation short review PR is simple enough to be reviewed quickly
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants