Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[OTAGENT-21] respect the FF metricremappingdisabled in serializer exporter #33560

Merged
merged 2 commits into from
Feb 7, 2025

Conversation

songy23
Copy link
Member

@songy23 songy23 commented Jan 29, 2025

What does this PR do?

Respect FF exporter.datadogexporter.metricremappingdisabled in serializer exporter. When enabled, the serializer exporter does not prepend otel prefix to OTel host metrics or otelcol prefix to trace agent internal metrics. For now it is disabled by default.

Motivation

In preparation of metric semantic convergence work.

Describe how you validated your changes

new unit tests

@songy23 songy23 added changelog/no-changelog team/opentelemetry OpenTelemetry team qa/done QA done before merge and regressions are covered by tests labels Jan 29, 2025
@songy23 songy23 added this to the 7.64.0 milestone Jan 29, 2025
@github-actions github-actions bot added the long review PR is complex, plan time to review it label Jan 29, 2025
Copy link

cit-pr-commenter bot commented Jan 29, 2025

Go Package Import Differences

Baseline: 82f052c
Comparison: 2078129

binaryosarchchange
agentlinuxamd64
+1, -0
+github.com/open-telemetry/opentelemetry-collector-contrib/pkg/datadog
agentlinuxarm64
+1, -0
+github.com/open-telemetry/opentelemetry-collector-contrib/pkg/datadog
agentwindowsamd64
+1, -0
+github.com/open-telemetry/opentelemetry-collector-contrib/pkg/datadog
agentdarwinamd64
+1, -0
+github.com/open-telemetry/opentelemetry-collector-contrib/pkg/datadog
agentdarwinarm64
+1, -0
+github.com/open-telemetry/opentelemetry-collector-contrib/pkg/datadog
iot-agentlinuxamd64
+1, -0
+github.com/open-telemetry/opentelemetry-collector-contrib/pkg/datadog
iot-agentlinuxarm64
+1, -0
+github.com/open-telemetry/opentelemetry-collector-contrib/pkg/datadog
heroku-agentlinuxamd64
+1, -0
+github.com/open-telemetry/opentelemetry-collector-contrib/pkg/datadog
serverlesslinuxamd64
+1, -0
+github.com/open-telemetry/opentelemetry-collector-contrib/pkg/datadog
serverlesslinuxarm64
+1, -0
+github.com/open-telemetry/opentelemetry-collector-contrib/pkg/datadog

@agent-platform-auto-pr
Copy link
Contributor

agent-platform-auto-pr bot commented Jan 29, 2025

Uncompressed package size comparison

Comparison with ancestor 82f052c6f96217e015ba12b12628b1dc2040eb7e

Diff per package
package diff status size ancestor threshold
datadog-iot-agent-aarch64-rpm 0.01MB ⚠️ 82.82MB 82.81MB 0.50MB
datadog-iot-agent-arm64-deb 0.01MB ⚠️ 82.75MB 82.74MB 0.50MB
datadog-iot-agent-x86_64-rpm 0.01MB ⚠️ 86.55MB 86.54MB 0.50MB
datadog-iot-agent-x86_64-suse 0.01MB ⚠️ 86.55MB 86.54MB 0.50MB
datadog-iot-agent-amd64-deb 0.01MB ⚠️ 86.48MB 86.47MB 0.50MB
datadog-agent-x86_64-rpm 0.00MB 883.40MB 883.40MB 0.50MB
datadog-agent-x86_64-suse 0.00MB 883.40MB 883.40MB 0.50MB
datadog-agent-amd64-deb 0.00MB 873.66MB 873.66MB 0.50MB
datadog-agent-arm64-deb 0.00MB 861.54MB 861.54MB 0.50MB
datadog-agent-aarch64-rpm 0.00MB 871.27MB 871.26MB 0.50MB
datadog-heroku-agent-amd64-deb 0.00MB 446.05MB 446.05MB 0.50MB
datadog-dogstatsd-amd64-deb 0.00MB 59.10MB 59.10MB 0.50MB
datadog-dogstatsd-x86_64-rpm 0.00MB 59.18MB 59.18MB 0.50MB
datadog-dogstatsd-x86_64-suse 0.00MB 59.18MB 59.18MB 0.50MB
datadog-dogstatsd-arm64-deb 0.00MB 56.57MB 56.57MB 0.50MB

Decision

⚠️ Warning

@agent-platform-auto-pr
Copy link
Contributor

agent-platform-auto-pr bot commented Jan 29, 2025

Test changes on VM

Use this command from test-infra-definitions to manually test this PR changes on a VM:

inv aws.create-vm --pipeline-id=55030424 --os-family=ubuntu

Note: This applies to commit 2078129

Copy link

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: b54a5df6-77b6-49b1-b13b-a7d95f73fdf4

Baseline: 2174ab4
Comparison: 72dc847
Diff

Optimization Goals: ✅ No significant changes detected

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
file_to_blackhole_1000ms_latency egress throughput +0.45 [-0.33, +1.23] 1 Logs
file_to_blackhole_500ms_latency egress throughput +0.28 [-0.49, +1.06] 1 Logs
file_to_blackhole_0ms_latency egress throughput +0.04 [-0.91, +0.99] 1 Logs
file_to_blackhole_100ms_latency egress throughput +0.03 [-0.77, +0.83] 1 Logs
uds_dogstatsd_to_api ingress throughput +0.01 [-0.28, +0.30] 1 Logs
file_to_blackhole_300ms_latency egress throughput +0.01 [-0.63, +0.64] 1 Logs
tcp_dd_logs_filter_exclude ingress throughput +0.01 [-0.02, +0.03] 1 Logs
file_to_blackhole_0ms_latency_http1 egress throughput +0.00 [-0.87, +0.87] 1 Logs
file_to_blackhole_0ms_latency_http2 egress throughput -0.02 [-0.94, +0.90] 1 Logs
file_to_blackhole_1000ms_latency_linear_load egress throughput -0.06 [-0.52, +0.40] 1 Logs
quality_gate_idle_all_features memory utilization -0.08 [-0.14, -0.03] 1 Logs bounds checks dashboard
file_tree memory utilization -0.11 [-0.17, -0.04] 1 Logs
quality_gate_idle memory utilization -0.28 [-0.32, -0.24] 1 Logs bounds checks dashboard
uds_dogstatsd_to_api_cpu % cpu utilization -0.83 [-1.73, +0.08] 1 Logs
tcp_syslog_to_blackhole ingress throughput -0.86 [-0.93, -0.78] 1 Logs
quality_gate_logs % cpu utilization -1.83 [-4.83, +1.17] 1 Logs

Bounds Checks: ✅ Passed

perf experiment bounds_check_name replicates_passed links
file_to_blackhole_0ms_latency lost_bytes 10/10
file_to_blackhole_0ms_latency memory_usage 10/10
file_to_blackhole_0ms_latency_http1 lost_bytes 10/10
file_to_blackhole_0ms_latency_http1 memory_usage 10/10
file_to_blackhole_0ms_latency_http2 lost_bytes 10/10
file_to_blackhole_0ms_latency_http2 memory_usage 10/10
file_to_blackhole_1000ms_latency memory_usage 10/10
file_to_blackhole_1000ms_latency_linear_load memory_usage 10/10
file_to_blackhole_100ms_latency lost_bytes 10/10
file_to_blackhole_100ms_latency memory_usage 10/10
file_to_blackhole_300ms_latency lost_bytes 10/10
file_to_blackhole_300ms_latency memory_usage 10/10
file_to_blackhole_500ms_latency lost_bytes 10/10
file_to_blackhole_500ms_latency memory_usage 10/10
quality_gate_idle intake_connections 10/10 bounds checks dashboard
quality_gate_idle memory_usage 10/10 bounds checks dashboard
quality_gate_idle_all_features intake_connections 10/10 bounds checks dashboard
quality_gate_idle_all_features memory_usage 10/10 bounds checks dashboard
quality_gate_logs intake_connections 10/10
quality_gate_logs lost_bytes 10/10
quality_gate_logs memory_usage 10/10

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

Passed. All Quality Gates passed.

  • quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.

@songy23 songy23 changed the title [OTEL-2409] respect the FF metricremappingdisabled in serializer exporter [OTAGENT-21] respect the FF metricremappingdisabled in serializer exporter Feb 5, 2025
@songy23 songy23 force-pushed the yang.song/OTEL-2409 branch from 72dc847 to 87a5dc2 Compare February 5, 2025 16:43
@github-actions github-actions bot added short review PR is simple enough to be reviewed quickly and removed long review PR is complex, plan time to review it labels Feb 5, 2025
@songy23 songy23 force-pushed the yang.song/OTEL-2409 branch from 87a5dc2 to 3e13412 Compare February 5, 2025 19:12
@songy23 songy23 requested a review from dineshg13 February 5, 2025 19:18
@songy23 songy23 marked this pull request as ready for review February 5, 2025 19:18
@songy23 songy23 requested review from a team as code owners February 5, 2025 19:18
@songy23 songy23 requested a review from truthbk February 5, 2025 19:18
@agent-platform-auto-pr
Copy link
Contributor

Static quality checks ✅

Please find below the results from static quality gates

Info

Result Quality gate On disk size On disk size limit On wire size On wire size limit
static_quality_gate_agent_deb_amd64 844.89MiB 858.45MiB 203.58MiB 214.3MiB
static_quality_gate_docker_agent_amd64 929.35MiB 942.69MiB 310.75MiB 321.56MiB

@github-actions github-actions bot added medium review PR review might take time and removed short review PR is simple enough to be reviewed quickly labels Feb 5, 2025
@songy23
Copy link
Member Author

songy23 commented Feb 7, 2025

/merge

@dd-devflow
Copy link

dd-devflow bot commented Feb 7, 2025

Devflow running: /merge

View all feedbacks in Devflow UI.


2025-02-07 02:23:00 UTC ℹ️ MergeQueue: pull request added to the queue

The median merge time in main is 29m.


2025-02-07 02:57:11 UTC ℹ️ MergeQueue: This merge request was merged

@dd-mergequeue dd-mergequeue bot merged commit df47013 into main Feb 7, 2025
230 of 234 checks passed
@dd-mergequeue dd-mergequeue bot deleted the yang.song/OTEL-2409 branch February 7, 2025 02:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog medium review PR review might take time qa/done QA done before merge and regressions are covered by tests team/opentelemetry OpenTelemetry team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants