Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(protobuf): Test the protoc version #33636

Merged
merged 3 commits into from
Feb 6, 2025
Merged

feat(protobuf): Test the protoc version #33636

merged 3 commits into from
Feb 6, 2025

Conversation

chouetz
Copy link
Member

@chouetz chouetz commented Jan 31, 2025 •
edited
Loading

What does this PR do?

  • Add a check on the protoc version and the tools during the test run, to ensure we are using the correct tooling
  • Update the test result to focus only on protobuf modified files
  • Add tests
  • Add a renovate custom manager to automatically update the protoc version

Motivation

  • Make the test more robust as it uses controlled version of dependencies.
  • Prevent false positive when a go.mod was modified in the git stack (and caught by the git status -suno).

Describe how you validated your changes

Local tests + delivered UT + renovate PR created on a personal repo

Possible Drawbacks / Trade-offs

Additional Notes

@chouetz chouetz added changelog/no-changelog qa/no-code-change No code change in Agent code requiring validation labels Jan 31, 2025
@chouetz chouetz requested review from a team as code owners January 31, 2025 18:08
@github-actions github-actions bot added the medium review PR review might take time label Feb 3, 2025
CelianR
CelianR approved these changes Feb 3, 2025
View reviewed changes
tasks/libs/common/check_tools_version.py Outdated Show resolved Hide resolved
tasks/protobuf.py Outdated Show resolved Hide resolved
tasks/unit_tests/libs/common/check_tools_tests.py Outdated Show resolved Hide resolved
GustavoCaso
GustavoCaso reviewed Feb 3, 2025
View reviewed changes
tasks/protobuf.py Outdated Show resolved Hide resolved
GustavoCaso
GustavoCaso reviewed Feb 3, 2025
View reviewed changes
tasks/protobuf.py Outdated Show resolved Hide resolved
@chouetz chouetz force-pushed the nschweitzer/protobuf branch from 707b03e to 316506c Compare February 4, 2025 15:18
@chouetz chouetz force-pushed the nschweitzer/protobuf branch from 316506c to c40480b Compare February 5, 2025 13:46
@agent-platform-auto-pr
Copy link
Contributor

Static quality checks ✅

Please find below the results from static quality gates

Info

Result Quality gate On disk size On disk size limit On wire size On wire size limit
✅ static_quality_gate_agent_deb_amd64 844.31MiB 858.45MiB 203.54MiB 214.3MiB
✅ static_quality_gate_docker_agent_amd64 929.14MiB 942.69MiB 310.69MiB 321.56MiB

@chouetz
Copy link
Member Author

chouetz commented Feb 6, 2025

/merge

@dd-devflow
Copy link

dd-devflow bot commented Feb 6, 2025 •
edited
Loading

Devflow running: /merge

View all feedbacks in Devflow UI.

2025-02-06 15:14:48 UTC ℹ️ MergeQueue: pull request added to the queue

The median merge time in main is 29m.

2025-02-06 15:43:22 UTC ℹ️ MergeQueue: This merge request was merged

@dd-mergequeue dd-mergequeue bot merged commit 987338d into main Feb 6, 2025
230 of 231 checks passed
@dd-mergequeue dd-mergequeue bot deleted the nschweitzer/protobuf branch February 6, 2025 15:43
@github-actions github-actions bot added this to the 7.64.0 milestone Feb 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GustavoCaso GustavoCaso GustavoCaso approved these changes

@CelianR CelianR CelianR approved these changes

Assignees
No one assigned
Labels
changelog/no-changelog medium review PR review might take time qa/no-code-change No code change in Agent code requiring validation
Projects
None yet
Milestone
7.64.0
Development

Successfully merging this pull request may close these issues.
3 participants
@chouetz @GustavoCaso @CelianR