Add jmx, dogstatsd, cluster-agent and arm64 images static quality gates #33754

Pythyu · 2025-02-05T16:44:06Z

What does this PR do?

Add static quality gates for arm64, jmx, dogstatsd and cluster-agent agent images

Motivation

RFC: P2 docker static quality gates

Describe how you validated your changes

Possible Drawbacks / Trade-offs

Additional Notes

agent-platform-auto-pr · 2025-02-05T16:53:34Z

Gitlab CI Configuration Changes

Modified Jobs

static_quality_gates

  static_quality_gates:
    allow_failure: true
    image: registry.ddbuild.io/ci/datadog-agent-buildimages/docker_x64$DATADOG_AGENT_BUILDIMAGES_SUFFIX:$DATADOG_AGENT_BUILDIMAGES
    needs:
    - artifacts: true
      job: agent_deb-x64-a7
    - artifacts: true
      job: docker_build_agent7
+   - artifacts: true
+     job: docker_build_agent7_arm64
+   - artifacts: true
+     job: docker_build_agent7_jmx
+   - artifacts: true
+     job: docker_build_agent7_jmx_arm64
+   - artifacts: true
+     job: docker_build_cluster_agent_amd64
+   - artifacts: true
+     job: docker_build_cluster_agent_arm64
    rules:
    - if: $CI_COMMIT_BRANCH =~ /^[0-9]+\.[0-9]+\.x$/
      when: never
    - if: $CI_COMMIT_TAG != null
      when: never
    - if: $CI_COMMIT_BRANCH =~ /^mq-working-branch-/
      when: never
    - when: on_success
    script:
    - DOCKER_LOGIN=$($CI_PROJECT_DIR/tools/ci/fetch_secret.sh $DOCKER_REGISTRY_RO user)
      || exit $?
    - $CI_PROJECT_DIR/tools/ci/fetch_secret.sh $DOCKER_REGISTRY_RO token | crane auth
      login --username "$DOCKER_LOGIN" --password-stdin "$DOCKER_REGISTRY_URL"
    - EXIT="${PIPESTATUS[0]}"; if [ $EXIT -ne 0 ]; then echo "Unable to locate credentials
      needs gitlab runner restart"; exit $EXIT; fi
    - DATADOG_API_KEY="$("$CI_PROJECT_DIR"/tools/ci/fetch_secret.sh "$AGENT_API_KEY_ORG2"
      token)" || exit $?; export DATADOG_API_KEY
    - export DD_API_KEY="$DATADOG_API_KEY"
    - GITHUB_KEY_B64=$($CI_PROJECT_DIR/tools/ci/fetch_secret.sh $AGENT_GITHUB_APP key_b64)
      || exit $?; export GITHUB_KEY_B64
    - GITHUB_APP_ID=$($CI_PROJECT_DIR/tools/ci/fetch_secret.sh $AGENT_GITHUB_APP app_id)
      || exit $?; export GITHUB_APP_ID
    - GITHUB_INSTALLATION_ID=$($CI_PROJECT_DIR/tools/ci/fetch_secret.sh $AGENT_GITHUB_APP
      installation_id) || exit $?; export GITHUB_INSTALLATION_ID
    - echo "Using agent GitHub App"
    - inv quality-gates.parse-and-trigger-gates
    stage: functional_test
    tags:
    - arch:amd64

Changes Summary

Removed	Modified	Added	Renamed
0	1	0	0

ℹ️ Diff available in the job log.

agent-platform-auto-pr · 2025-02-05T17:20:06Z

[Fast Unit Tests Report]

On pipeline 55266373 (CI Visibility). The following jobs did not run any unit tests:

Jobs:

tests_deb-arm64-py3
tests_deb-x64-py3
tests_flavor_dogstatsd_deb-x64
tests_flavor_heroku_deb-x64
tests_flavor_iot_deb-x64
tests_rpm-arm64-py3
tests_rpm-x64-py3
tests_windows-x64

If you modified Go files and expected unit tests to run in these jobs, please double check the job logs. If you think tests should have been executed reach out to #agent-devx-help

agent-platform-auto-pr · 2025-02-05T17:20:09Z

Uncompressed package size comparison

Comparison with ancestor 909942b64fda2a3bdb7f79562115cde9e3cacd94

Diff per package

package	diff	status	size	ancestor	threshold
datadog-agent-amd64-deb	0.00MB	✅	873.70MB	873.70MB	0.50MB
datadog-agent-x86_64-rpm	0.00MB	✅	883.44MB	883.44MB	0.50MB
datadog-agent-x86_64-suse	0.00MB	✅	883.44MB	883.44MB	0.50MB
datadog-agent-arm64-deb	0.00MB	✅	861.58MB	861.58MB	0.50MB
datadog-dogstatsd-amd64-deb	0.00MB	✅	59.10MB	59.10MB	0.50MB
datadog-dogstatsd-x86_64-rpm	0.00MB	✅	59.18MB	59.18MB	0.50MB
datadog-dogstatsd-x86_64-suse	0.00MB	✅	59.18MB	59.18MB	0.50MB
datadog-dogstatsd-arm64-deb	0.00MB	✅	56.57MB	56.57MB	0.50MB
datadog-heroku-agent-amd64-deb	0.00MB	✅	445.90MB	445.90MB	0.50MB
datadog-iot-agent-amd64-deb	0.00MB	✅	86.37MB	86.37MB	0.50MB
datadog-iot-agent-x86_64-rpm	0.00MB	✅	86.44MB	86.44MB	0.50MB
datadog-iot-agent-x86_64-suse	0.00MB	✅	86.44MB	86.44MB	0.50MB
datadog-iot-agent-arm64-deb	0.00MB	✅	82.64MB	82.64MB	0.50MB
datadog-iot-agent-aarch64-rpm	0.00MB	✅	82.71MB	82.71MB	0.50MB
datadog-agent-aarch64-rpm	-0.00MB	✅	871.30MB	871.30MB	0.50MB

Decision

✅ Passed

cit-pr-commenter · 2025-02-05T17:49:10Z

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: 1992498c-20be-495e-84f1-7105f3b5e5d2

Baseline: 909942b
Comparison: acf4a26
Diff

Optimization Goals: ✅ No significant changes detected

Fine details of change detection per experiment

perf	experiment	goal	Δ mean %	Δ mean % CI	trials	links
➖	quality_gate_logs	% cpu utilization	+1.03	[-2.05, +4.10]	1	Logs
➖	file_to_blackhole_0ms_latency	egress throughput	+0.18	[-0.72, +1.09]	1	Logs
➖	quality_gate_idle	memory utilization	+0.17	[+0.12, +0.21]	1	Logs bounds checks dashboard
➖	file_to_blackhole_0ms_latency_http2	egress throughput	+0.08	[-0.82, +0.99]	1	Logs
➖	file_to_blackhole_100ms_latency	egress throughput	+0.03	[-0.60, +0.66]	1	Logs
➖	uds_dogstatsd_to_api	ingress throughput	+0.03	[-0.25, +0.31]	1	Logs
➖	tcp_dd_logs_filter_exclude	ingress throughput	-0.01	[-0.02, +0.01]	1	Logs
➖	file_to_blackhole_0ms_latency_http1	egress throughput	-0.01	[-0.90, +0.87]	1	Logs
➖	file_to_blackhole_300ms_latency	egress throughput	-0.01	[-0.65, +0.62]	1	Logs
➖	file_tree	memory utilization	-0.03	[-0.10, +0.04]	1	Logs
➖	file_to_blackhole_1000ms_latency_linear_load	egress throughput	-0.10	[-0.57, +0.37]	1	Logs
➖	file_to_blackhole_500ms_latency	egress throughput	-0.12	[-0.91, +0.66]	1	Logs
➖	quality_gate_idle_all_features	memory utilization	-0.37	[-0.42, -0.31]	1	Logs bounds checks dashboard
➖	uds_dogstatsd_to_api_cpu	% cpu utilization	-0.43	[-1.29, +0.44]	1	Logs
➖	file_to_blackhole_1000ms_latency	egress throughput	-0.79	[-1.57, -0.00]	1	Logs
➖	tcp_syslog_to_blackhole	ingress throughput	-1.17	[-1.24, -1.10]	1	Logs

Bounds Checks: ✅ Passed

perf	experiment	bounds_check_name	replicates_passed	links
✅	file_to_blackhole_0ms_latency	lost_bytes	10/10
✅	file_to_blackhole_0ms_latency	memory_usage	10/10
✅	file_to_blackhole_0ms_latency_http1	lost_bytes	10/10
✅	file_to_blackhole_0ms_latency_http1	memory_usage	10/10
✅	file_to_blackhole_0ms_latency_http2	lost_bytes	10/10
✅	file_to_blackhole_0ms_latency_http2	memory_usage	10/10
✅	file_to_blackhole_1000ms_latency	memory_usage	10/10
✅	file_to_blackhole_1000ms_latency_linear_load	memory_usage	10/10
✅	file_to_blackhole_100ms_latency	lost_bytes	10/10
✅	file_to_blackhole_100ms_latency	memory_usage	10/10
✅	file_to_blackhole_300ms_latency	lost_bytes	10/10
✅	file_to_blackhole_300ms_latency	memory_usage	10/10
✅	file_to_blackhole_500ms_latency	lost_bytes	10/10
✅	file_to_blackhole_500ms_latency	memory_usage	10/10
✅	quality_gate_idle	intake_connections	10/10	bounds checks dashboard
✅	quality_gate_idle	memory_usage	10/10	bounds checks dashboard
✅	quality_gate_idle_all_features	intake_connections	10/10	bounds checks dashboard
✅	quality_gate_idle_all_features	memory_usage	10/10	bounds checks dashboard
✅	quality_gate_logs	intake_connections	10/10
✅	quality_gate_logs	lost_bytes	10/10
✅	quality_gate_logs	memory_usage	10/10

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

✅ = significantly better comparison variant performance
❌ = significantly worse comparison variant performance
➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.
Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.
Its configuration does not mark it "erratic".

CI Pass/Fail Decision

✅ Passed. All Quality Gates passed.

quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.

CelianR

Added some NITs to clean the previous code 👍

tasks/static_quality_gates/lib/docker_agent_lib.py

Co-authored-by: Célian Raimbault <[email protected]>

…datadog-agent into pythyu/arm_and_jmx_docker_gates

agent-platform-auto-pr · 2025-02-07T16:44:19Z

Static quality checks ✅

Please find below the results from static quality gates

Info

Result	Quality gate	On disk size	On disk size limit	On wire size	On wire size limit
✅	static_quality_gate_agent_deb_amd64	844.56MiB	858.45MiB	203.61MiB	214.3MiB
✅	static_quality_gate_docker_agent_amd64	929.36MiB	942.69MiB	310.74MiB	321.56MiB
✅	static_quality_gate_docker_agent_arm64	941.12MiB	952.69MiB	294.5MiB	351.22MiB
✅	static_quality_gate_docker_agent_jmx_amd64	1.1GiB	1.11GiB	385.83MiB	395.8MiB
✅	static_quality_gate_docker_agent_jmx_arm64	1.1GiB	1.11GiB	365.58MiB	375.5MiB
✅	static_quality_gate_docker_dogstatsd_amd64	47.89MiB	57.88MiB	18.3MiB	28.29MiB
✅	static_quality_gate_docker_dogstatsd_arm64	46.27MiB	56.27MiB	17.06MiB	27.06MiB
✅	static_quality_gate_docker_cluster_agent_amd64	267.75MiB	277.7MiB	107.29MiB	117.28MiB
✅	static_quality_gate_docker_cluster_agent_arm64	283.77MiB	293.73MiB	102.13MiB	112.12MiB

Pythyu · 2025-02-10T08:29:31Z

/merge

dd-devflow · 2025-02-10T08:29:38Z

Devflow running: `/merge`

View all feedbacks in Devflow UI.

2025-02-10 08:29:37 UTC ℹ️ MergeQueue: pull request added to the queue

The median merge time in main is 29m.

2025-02-10 08:57:41 UTC ℹ️ MergeQueue: This merge request was merged

Pythyu added 6 commits February 5, 2025 17:01

feat(docker): gate metrics fixed

2cbde00

feat(linter): python

997a1a6

feat(gitlab): not running static quality gates on merge queue

131341a

feat(gitlab): not running static quality gates on merge queue

966657d

feat(gitlab): not running static quality gates on merge queue

200eeb2

feat(Quality Gates): Add more docker image static quality gates

44b2361

Pythyu added changelog/no-changelog qa/no-code-change No code change in Agent code requiring validation labels Feb 5, 2025

Pythyu requested a review from a team as a code owner February 5, 2025 16:44

github-actions bot added the short review PR is simple enough to be reviewed quickly label Feb 5, 2025

feat(config): add static quality gates config for new gates

11b9299

github-actions bot added medium review PR review might take time and removed short review PR is simple enough to be reviewed quickly labels Feb 5, 2025

feat(gates): new gates

3f6cdbc

Pythyu added 3 commits February 6, 2025 10:02

fix(unit): fix unit tests

b2f903d

feat(unit): better unit tests

7c235d6

feat(quality_gates): define generic_docker_agent_quality_gate

10ae958

Pythyu requested review from a team as code owners February 6, 2025 13:02

feat(gates): added dogstatsd and cluster_agent quality gates

e52fb97

DataDog deleted a comment from agent-platform-auto-pr bot Feb 7, 2025

Pythyu added 4 commits February 7, 2025 11:27

fix(gate): url fix

4307d3c

fix(gate): wrong gate parameter

46f401a

fix(gate): wrong gate parameter

aebe8f5

feat(gates): better dependencies and details on disk image extraction

61e246c

DataDog deleted a comment from agent-platform-auto-pr bot Feb 7, 2025

feat(gates): update upper bound values

f4fb0de

DataDog deleted a comment from agent-platform-auto-pr bot Feb 7, 2025

Merge branch 'main' into pythyu/arm_and_jmx_docker_gates

be69969

Pythyu changed the title ~~Add arm64 and jmx images static quality gates~~ Add jmx, dogstatsd, cluster-agent and arm64 images static quality gates Feb 7, 2025

CelianR approved these changes Feb 7, 2025

View reviewed changes

tasks/static_quality_gates/lib/docker_agent_lib.py Outdated Show resolved Hide resolved

tasks/static_quality_gates/lib/docker_agent_lib.py Outdated Show resolved Hide resolved

tasks/static_quality_gates/lib/docker_agent_lib.py Outdated Show resolved Hide resolved

Pythyu and others added 4 commits February 7, 2025 17:05

Update tasks/static_quality_gates/lib/docker_agent_lib.py

4006b25

Co-authored-by: Célian Raimbault <[email protected]>

Update tasks/static_quality_gates/lib/docker_agent_lib.py

3f1304c

Co-authored-by: Célian Raimbault <[email protected]>

WIP

6337576

Merge branch 'pythyu/arm_and_jmx_docker_gates' of github.com:DataDog/…

acf4a26

…datadog-agent into pythyu/arm_and_jmx_docker_gates

DataDog deleted a comment from agent-platform-auto-pr bot Feb 7, 2025

FlorentClarret approved these changes Feb 10, 2025

View reviewed changes

dd-mergequeue bot merged commit 9895bca into main Feb 10, 2025
228 of 230 checks passed

dd-mergequeue bot deleted the pythyu/arm_and_jmx_docker_gates branch February 10, 2025 08:57

github-actions bot added this to the 7.64.0 milestone Feb 10, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add jmx, dogstatsd, cluster-agent and arm64 images static quality gates #33754

Add jmx, dogstatsd, cluster-agent and arm64 images static quality gates #33754

Pythyu commented Feb 5, 2025 •

edited

Loading

agent-platform-auto-pr bot commented Feb 5, 2025 •

edited

Loading

agent-platform-auto-pr bot commented Feb 5, 2025 •

edited

Loading

agent-platform-auto-pr bot commented Feb 5, 2025 •

edited

Loading

cit-pr-commenter bot commented Feb 5, 2025 •

edited

Loading

Fine details of change detection per experiment

Bounds Checks: ✅ Passed

Explanation

CelianR left a comment

agent-platform-auto-pr bot commented Feb 7, 2025

Pythyu commented Feb 10, 2025

dd-devflow bot commented Feb 10, 2025 •

edited

Loading

Add jmx, dogstatsd, cluster-agent and arm64 images static quality gates #33754

Add jmx, dogstatsd, cluster-agent and arm64 images static quality gates #33754

Conversation

Pythyu commented Feb 5, 2025 • edited Loading

What does this PR do?

Motivation

Describe how you validated your changes

Possible Drawbacks / Trade-offs

Additional Notes

agent-platform-auto-pr bot commented Feb 5, 2025 • edited Loading

Gitlab CI Configuration Changes

Modified Jobs

Changes Summary

agent-platform-auto-pr bot commented Feb 5, 2025 • edited Loading

agent-platform-auto-pr bot commented Feb 5, 2025 • edited Loading

Uncompressed package size comparison

Decision

cit-pr-commenter bot commented Feb 5, 2025 • edited Loading

Regression Detector

Regression Detector Results

Optimization Goals: ✅ No significant changes detected

Fine details of change detection per experiment

Bounds Checks: ✅ Passed

Explanation

CI Pass/Fail Decision

CelianR left a comment

Choose a reason for hiding this comment

agent-platform-auto-pr bot commented Feb 7, 2025

Static quality checks ✅

Info

Pythyu commented Feb 10, 2025

dd-devflow bot commented Feb 10, 2025 • edited Loading

Devflow running: /merge

Pythyu commented Feb 5, 2025 •

edited

Loading

agent-platform-auto-pr bot commented Feb 5, 2025 •

edited

Loading

agent-platform-auto-pr bot commented Feb 5, 2025 •

edited

Loading

agent-platform-auto-pr bot commented Feb 5, 2025 •

edited

Loading

cit-pr-commenter bot commented Feb 5, 2025 •

edited

Loading

dd-devflow bot commented Feb 10, 2025 •

edited

Loading

Devflow running: `/merge`