Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[network path] Update dynamic path limits #33757

Merged
merged 7 commits into from
Feb 6, 2025
Merged

Conversation

AlexandreYang
Copy link
Member

@AlexandreYang AlexandreYang commented Feb 5, 2025

What does this PR do?

[network path] Update dynamic path limits

Motivation

High channel size can lead to higher memory usage.
User can still increase manually limits if needed.
We might consider in the future to set higher limits if needed (if too many customer need to manually bump the limit).

Describe how you validated your changes

Possible Drawbacks / Trade-offs

Additional Notes

@agent-platform-auto-pr
Copy link
Contributor

agent-platform-auto-pr bot commented Feb 5, 2025

Static quality checks ✅

Please find below the results from static quality gates

Info

Result Quality gate On disk size On disk size limit On wire size On wire size limit
static_quality_gate_agent_deb_amd64 844.81MiB 858.45MiB 203.61MiB 214.3MiB
static_quality_gate_docker_agent_amd64 929.15MiB 942.69MiB 310.69MiB 321.56MiB

@agent-platform-auto-pr
Copy link
Contributor

agent-platform-auto-pr bot commented Feb 5, 2025

Uncompressed package size comparison

Comparison with ancestor 00bbb32a2a2232e78182c40ad5fb5f7758ee2f56

Diff per package
package diff status size ancestor threshold
datadog-agent-amd64-deb 0.00MB 873.45MB 873.45MB 0.50MB
datadog-agent-x86_64-rpm 0.00MB 883.19MB 883.19MB 0.50MB
datadog-agent-x86_64-suse 0.00MB 883.19MB 883.19MB 0.50MB
datadog-agent-arm64-deb 0.00MB 861.34MB 861.34MB 0.50MB
datadog-agent-aarch64-rpm 0.00MB 871.06MB 871.06MB 0.50MB
datadog-dogstatsd-amd64-deb 0.00MB 59.09MB 59.09MB 0.50MB
datadog-dogstatsd-x86_64-rpm 0.00MB 59.17MB 59.17MB 0.50MB
datadog-dogstatsd-x86_64-suse 0.00MB 59.17MB 59.17MB 0.50MB
datadog-dogstatsd-arm64-deb 0.00MB 56.56MB 56.56MB 0.50MB
datadog-heroku-agent-amd64-deb 0.00MB 445.70MB 445.70MB 0.50MB
datadog-iot-agent-amd64-deb 0.00MB 86.23MB 86.23MB 0.50MB
datadog-iot-agent-x86_64-rpm 0.00MB 86.30MB 86.30MB 0.50MB
datadog-iot-agent-x86_64-suse 0.00MB 86.30MB 86.30MB 0.50MB
datadog-iot-agent-arm64-deb 0.00MB 82.50MB 82.50MB 0.50MB
datadog-iot-agent-aarch64-rpm 0.00MB 82.57MB 82.57MB 0.50MB

Decision

✅ Passed

@agent-platform-auto-pr
Copy link
Contributor

agent-platform-auto-pr bot commented Feb 5, 2025

Test changes on VM

Use this command from test-infra-definitions to manually test this PR changes on a VM:

inv aws.create-vm --pipeline-id=55016644 --os-family=ubuntu

Note: This applies to commit cb99faf

Base automatically changed from alex/dynamic_path_metrics to main February 5, 2025 17:50
Copy link

cit-pr-commenter bot commented Feb 5, 2025

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: 6f6e1158-5e0f-4bbd-b96e-0dd5c2a88f24

Baseline: 00bbb32
Comparison: cb99faf
Diff

Optimization Goals: ✅ No significant changes detected

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
quality_gate_logs % cpu utilization +1.34 [-1.68, +4.35] 1 Logs
file_to_blackhole_0ms_latency egress throughput +0.05 [-0.81, +0.92] 1 Logs
file_to_blackhole_0ms_latency_http2 egress throughput +0.04 [-0.76, +0.85] 1 Logs
file_to_blackhole_100ms_latency egress throughput +0.02 [-0.68, +0.72] 1 Logs
tcp_dd_logs_filter_exclude ingress throughput +0.01 [-0.01, +0.04] 1 Logs
file_to_blackhole_300ms_latency egress throughput +0.00 [-0.64, +0.64] 1 Logs
uds_dogstatsd_to_api ingress throughput +0.00 [-0.30, +0.30] 1 Logs
file_to_blackhole_0ms_latency_http1 egress throughput -0.03 [-0.90, +0.84] 1 Logs
file_to_blackhole_1000ms_latency_linear_load egress throughput -0.11 [-0.59, +0.36] 1 Logs
file_to_blackhole_500ms_latency egress throughput -0.13 [-0.91, +0.66] 1 Logs
file_to_blackhole_1000ms_latency egress throughput -0.39 [-1.17, +0.40] 1 Logs
tcp_syslog_to_blackhole ingress throughput -0.47 [-0.55, -0.38] 1 Logs
quality_gate_idle memory utilization -0.61 [-0.66, -0.57] 1 Logs bounds checks dashboard
file_tree memory utilization -0.84 [-0.90, -0.78] 1 Logs
quality_gate_idle_all_features memory utilization -1.21 [-1.29, -1.14] 1 Logs bounds checks dashboard
uds_dogstatsd_to_api_cpu % cpu utilization -1.37 [-2.25, -0.49] 1 Logs

Bounds Checks: ✅ Passed

perf experiment bounds_check_name replicates_passed links
file_to_blackhole_0ms_latency lost_bytes 10/10
file_to_blackhole_0ms_latency memory_usage 10/10
file_to_blackhole_0ms_latency_http1 lost_bytes 10/10
file_to_blackhole_0ms_latency_http1 memory_usage 10/10
file_to_blackhole_0ms_latency_http2 lost_bytes 10/10
file_to_blackhole_0ms_latency_http2 memory_usage 10/10
file_to_blackhole_1000ms_latency memory_usage 10/10
file_to_blackhole_1000ms_latency_linear_load memory_usage 10/10
file_to_blackhole_100ms_latency lost_bytes 10/10
file_to_blackhole_100ms_latency memory_usage 10/10
file_to_blackhole_300ms_latency lost_bytes 10/10
file_to_blackhole_300ms_latency memory_usage 10/10
file_to_blackhole_500ms_latency lost_bytes 10/10
file_to_blackhole_500ms_latency memory_usage 10/10
quality_gate_idle intake_connections 10/10 bounds checks dashboard
quality_gate_idle memory_usage 10/10 bounds checks dashboard
quality_gate_idle_all_features intake_connections 10/10 bounds checks dashboard
quality_gate_idle_all_features memory_usage 10/10 bounds checks dashboard
quality_gate_logs intake_connections 10/10
quality_gate_logs lost_bytes 10/10
quality_gate_logs memory_usage 10/10

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

Passed. All Quality Gates passed.

  • quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.

@AlexandreYang AlexandreYang marked this pull request as ready for review February 5, 2025 18:11
@AlexandreYang AlexandreYang requested review from a team as code owners February 5, 2025 18:11
@github-actions github-actions bot added team/agent-configuration short review PR is simple enough to be reviewed quickly labels Feb 5, 2025
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we consts that declared on the package?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AmitaiBl ,
Those default values are currently only used in config.go and not needed elsewhere (besides tests), I think it's fine to just keep the literal here, similar to many other cases in this config.go file.

About using the literal values in tests, I would preferred to use literal to check value, if we use constants that will make IMHO the test less reliable (having to rewrite the literal default value is a kind of double writing in accounting, it helps you verify/sanity check)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AmitaiBl It's likely a matter of preference here,
so let me know if that's blocker, if so, I try to adjust :)

@github-actions github-actions bot added medium review PR review might take time and removed short review PR is simple enough to be reviewed quickly labels Feb 5, 2025
@AlexandreYang AlexandreYang added the qa/done QA done before merge and regressions are covered by tests label Feb 6, 2025
Copy link
Contributor

@dustmop dustmop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for agent-configuration

@dustmop dustmop removed the request for review from hush-hush February 6, 2025 14:12
@AlexandreYang
Copy link
Member Author

/merge

@dd-devflow
Copy link

dd-devflow bot commented Feb 6, 2025

Devflow running: /merge

View all feedbacks in Devflow UI.


2025-02-06 18:21:25 UTC ℹ️ MergeQueue: pull request added to the queue

The median merge time in main is 29m.


2025-02-06 19:05:40 UTC ℹ️ MergeQueue: This merge request was merged

@dd-mergequeue dd-mergequeue bot merged commit 2d95154 into main Feb 6, 2025
244 of 248 checks passed
@dd-mergequeue dd-mergequeue bot deleted the alex/dynamic_path_limits branch February 6, 2025 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog medium review PR review might take time qa/done QA done before merge and regressions are covered by tests team/agent-configuration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants