Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: asm serverless upgrade #33790

Open
wants to merge 20 commits into
base: main
Choose a base branch
from

Conversation

genesor
Copy link

@genesor genesor commented Feb 6, 2025

What does this PR do?

This PR updates the appsec-internal-go to v1.10.0 with an updated ruleset

It also adds some appsec related tags that were missing in the serverless agent.

Describe how you validated your changes

New integration tests validating the presence of appsec related tags in the normalized logs, their value does not really matter so checking their non emptiness is enough.

The format of the appsec snapshot have changed to fit this new need. In the previous format each entry was the content of the _dd.appsec.json meta tag. Now the snapshot entries are made of appsec.json and tags.

{
    "appsec.json": { 
		%content of the _dd.appsec.json tag%
	},
    "tags": {
      "_dd.appsec.event_rules.error_count": "NOT_FOUND",
      "_dd.appsec.event_rules.errors": "NOT_FOUND",
      "_dd.appsec.event_rules.loaded": "NOT_FOUND",
      "_dd.appsec.event_rules.version": "FOUND",
      "_dd.appsec.waf.duration_ext": "FOUND",
      "_dd.appsec.waf.version": "NOT_FOUND",
      "_dd.origin": "FOUND",
      "appsec.event": "FOUND"
    }
}

@bits-bot
Copy link
Collaborator

bits-bot commented Feb 6, 2025

CLA assistant check
All committers have signed the CLA.

@genesor genesor force-pushed the ben.db/APPSEC-56208-asm-serverless-upgrade branch from d644586 to 07013f4 Compare February 6, 2025 15:49
@github-actions github-actions bot added the long review PR is complex, plan time to review it label Feb 6, 2025
@genesor genesor force-pushed the ben.db/APPSEC-56208-asm-serverless-upgrade branch from 07013f4 to 05e7170 Compare February 6, 2025 16:02
@agent-platform-auto-pr
Copy link
Contributor

agent-platform-auto-pr bot commented Feb 6, 2025

Static quality checks ✅

Please find below the results from static quality gates

Info

Result Quality gate On disk size On disk size limit On wire size On wire size limit
static_quality_gate_agent_deb_amd64 837.64MiB 847.49MiB 202.74MiB 212.83MiB
static_quality_gate_docker_agent_amd64 921.96MiB 931.7MiB 308.76MiB 318.67MiB
static_quality_gate_docker_agent_arm64 934.31MiB 944.08MiB 292.75MiB 303.0MiB
static_quality_gate_docker_agent_jmx_amd64 1.09GiB 1.11GiB 383.88MiB 393.75MiB
static_quality_gate_docker_agent_jmx_arm64 1.09GiB 1.11GiB 363.82MiB 373.71MiB
static_quality_gate_docker_dogstatsd_amd64 47.86MiB 57.88MiB 18.29MiB 28.29MiB
static_quality_gate_docker_dogstatsd_arm64 46.25MiB 56.27MiB 17.04MiB 27.06MiB
static_quality_gate_docker_cluster_agent_amd64 267.76MiB 277.7MiB 107.3MiB 117.28MiB
static_quality_gate_docker_cluster_agent_arm64 283.81MiB 293.73MiB 102.14MiB 112.12MiB

@agent-platform-auto-pr
Copy link
Contributor

agent-platform-auto-pr bot commented Feb 6, 2025

Uncompressed package size comparison

Comparison with ancestor f81d11dc16d7629801ab58d059ee7150e0e46751

Diff per package
package diff status size ancestor threshold
datadog-agent-amd64-deb 0.01MB ⚠️ 865.92MB 865.91MB 0.50MB
datadog-agent-x86_64-rpm 0.01MB ⚠️ 875.69MB 875.68MB 0.50MB
datadog-agent-x86_64-suse 0.01MB ⚠️ 875.69MB 875.68MB 0.50MB
datadog-agent-arm64-deb 0.00MB 854.41MB 854.41MB 0.50MB
datadog-agent-aarch64-rpm 0.00MB 864.15MB 864.15MB 0.50MB
datadog-dogstatsd-amd64-deb 0.00MB 41.57MB 41.57MB 0.50MB
datadog-dogstatsd-x86_64-rpm 0.00MB 41.65MB 41.65MB 0.50MB
datadog-dogstatsd-x86_64-suse 0.00MB 41.65MB 41.65MB 0.50MB
datadog-dogstatsd-arm64-deb 0.00MB 39.83MB 39.83MB 0.50MB
datadog-heroku-agent-amd64-deb 0.00MB 441.05MB 441.05MB 0.50MB
datadog-iot-agent-amd64-deb 0.00MB 61.76MB 61.76MB 0.50MB
datadog-iot-agent-x86_64-rpm 0.00MB 61.83MB 61.83MB 0.50MB
datadog-iot-agent-x86_64-suse 0.00MB 61.83MB 61.83MB 0.50MB
datadog-iot-agent-arm64-deb 0.00MB 59.01MB 59.01MB 0.50MB
datadog-iot-agent-aarch64-rpm 0.00MB 59.08MB 59.08MB 0.50MB

Decision

⚠️ Warning

Copy link

cit-pr-commenter bot commented Feb 6, 2025

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: cce2a4e9-5d09-42d0-bcc2-dc583f006b59

Baseline: f81d11d
Comparison: 60b3673
Diff

Optimization Goals: ✅ No significant changes detected

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
quality_gate_logs % cpu utilization +4.22 [+1.08, +7.36] 1 Logs
file_to_blackhole_500ms_latency egress throughput +0.39 [-0.39, +1.17] 1 Logs
quality_gate_idle_all_features memory utilization +0.39 [+0.33, +0.44] 1 Logs bounds checks dashboard
file_to_blackhole_0ms_latency_http2 egress throughput +0.07 [-0.84, +0.99] 1 Logs
file_to_blackhole_1000ms_latency_linear_load egress throughput +0.04 [-0.42, +0.50] 1 Logs
file_tree memory utilization +0.04 [-0.02, +0.10] 1 Logs
file_to_blackhole_300ms_latency egress throughput +0.01 [-0.63, +0.65] 1 Logs
file_to_blackhole_100ms_latency egress throughput +0.01 [-0.66, +0.67] 1 Logs
tcp_dd_logs_filter_exclude ingress throughput -0.00 [-0.01, +0.01] 1 Logs
file_to_blackhole_0ms_latency_http1 egress throughput -0.00 [-0.86, +0.86] 1 Logs
file_to_blackhole_0ms_latency egress throughput -0.01 [-0.92, +0.89] 1 Logs
uds_dogstatsd_to_api ingress throughput -0.02 [-0.30, +0.26] 1 Logs
uds_dogstatsd_to_api_cpu % cpu utilization -0.25 [-1.16, +0.66] 1 Logs
quality_gate_idle memory utilization -0.35 [-0.40, -0.29] 1 Logs bounds checks dashboard
file_to_blackhole_1000ms_latency egress throughput -0.47 [-1.23, +0.28] 1 Logs
tcp_syslog_to_blackhole ingress throughput -1.55 [-1.61, -1.48] 1 Logs

Bounds Checks: ✅ Passed

perf experiment bounds_check_name replicates_passed links
file_to_blackhole_0ms_latency lost_bytes 10/10
file_to_blackhole_0ms_latency memory_usage 10/10
file_to_blackhole_0ms_latency_http1 lost_bytes 10/10
file_to_blackhole_0ms_latency_http1 memory_usage 10/10
file_to_blackhole_0ms_latency_http2 lost_bytes 10/10
file_to_blackhole_0ms_latency_http2 memory_usage 10/10
file_to_blackhole_1000ms_latency memory_usage 10/10
file_to_blackhole_1000ms_latency_linear_load memory_usage 10/10
file_to_blackhole_100ms_latency lost_bytes 10/10
file_to_blackhole_100ms_latency memory_usage 10/10
file_to_blackhole_300ms_latency lost_bytes 10/10
file_to_blackhole_300ms_latency memory_usage 10/10
file_to_blackhole_500ms_latency lost_bytes 10/10
file_to_blackhole_500ms_latency memory_usage 10/10
quality_gate_idle intake_connections 10/10 bounds checks dashboard
quality_gate_idle memory_usage 10/10 bounds checks dashboard
quality_gate_idle_all_features intake_connections 10/10 bounds checks dashboard
quality_gate_idle_all_features memory_usage 10/10 bounds checks dashboard
quality_gate_logs intake_connections 10/10
quality_gate_logs lost_bytes 10/10
quality_gate_logs memory_usage 10/10

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

Passed. All Quality Gates passed.

  • quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.

@genesor genesor force-pushed the ben.db/APPSEC-56208-asm-serverless-upgrade branch from 2212802 to c3f7aa4 Compare February 7, 2025 14:17
@genesor genesor marked this pull request as ready for review February 7, 2025 14:31
@genesor genesor requested review from a team as code owners February 7, 2025 14:31
pkg/serverless/appsec/appsec_test.go Outdated Show resolved Hide resolved
pkg/serverless/appsec/httpsec/http.go Show resolved Hide resolved
pkg/serverless/appsec/httpsec/proxy.go Outdated Show resolved Hide resolved
pkg/serverless/appsec/httpsec/proxy.go Outdated Show resolved Hide resolved
pkg/serverless/appsec/httpsec/proxy.go Outdated Show resolved Hide resolved
pkg/serverless/appsec/httpsec/tags.go Outdated Show resolved Hide resolved
pkg/serverless/appsec/httpsec/tags.go Show resolved Hide resolved
test/integration/serverless/src/go-tests/appsec/main.go Outdated Show resolved Hide resolved
test/integration/serverless/src/go.mod Outdated Show resolved Hide resolved
@genesor genesor requested a review from RomainMuller February 7, 2025 16:18
@agent-platform-auto-pr
Copy link
Contributor

agent-platform-auto-pr bot commented Feb 7, 2025

Test changes on VM

Use this command from test-infra-definitions to manually test this PR changes on a VM:

inv aws.create-vm --pipeline-id=55776471 --os-family=ubuntu

Note: This applies to commit 60b3673

@genesor genesor requested review from a team as code owners February 11, 2025 14:27
go.work Outdated Show resolved Hide resolved
Copy link
Contributor

@dustmop dustmop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for agent-configuration changes.

@genesor genesor force-pushed the ben.db/APPSEC-56208-asm-serverless-upgrade branch 2 times, most recently from 88f957e to 52d631f Compare February 12, 2025 14:10
@genesor
Copy link
Author

genesor commented Feb 12, 2025

Currently waiting on #33988 to be merged to fix the Serverless Integration Tests

Copy link
Contributor

Serverless Benchmark Results

BenchmarkStartEndInvocation comparison between f81d11d and abff78e.

tl;dr

Use these benchmarks as an insight tool during development.

  1. Skim down the vs base column in each chart. If there is a ~, then there was no statistically significant change to the benchmark. Otherwise, ensure the estimated percent change is either negative or very small.

  2. The last row of each chart is the geomean. Ensure this percentage is either negative or very small.

What is this benchmarking?

The BenchmarkStartEndInvocation compares the amount of time it takes to call the start-invocation and end-invocation endpoints. For universal instrumentation languages (Dotnet, Golang, Java, Ruby), this represents the majority of the duration overhead added by our tracing layer.

The benchmark is run using a large variety of lambda request payloads. In the charts below, there is one row for each event payload type.

How do I interpret these charts?

The charts below comes from benchstat. They represent the statistical change in duration (sec/op), memory overhead (B/op), and allocations (allocs/op).

The benchstat docs explain how to interpret these charts.

Before the comparison table, we see common file-level configuration. If there are benchmarks with different configuration (for example, from different packages), benchstat will print separate tables for each configuration.

The table then compares the two input files for each benchmark. It shows the median and 95% confidence interval summaries for each benchmark before and after the change, and an A/B comparison under "vs base". ... The p-value measures how likely it is that any differences were due to random chance (i.e., noise). The "~" means benchstat did not detect a statistically significant difference between the two inputs. ...

Note that "statistically significant" is not the same as "large": with enough low-noise data, even very small changes can be distinguished from noise and considered statistically significant. It is, of course, generally easier to distinguish large changes from noise.

Finally, the last row of the table shows the geometric mean of each column, giving an overall picture of how the benchmarks changed. Proportional changes in the geomean reflect proportional changes in the benchmarks. For example, given n benchmarks, if sec/op for one of them increases by a factor of 2, then the sec/op geomean will increase by a factor of ⁿ√2.

I need more help

First off, do not worry if the benchmarks are failing. They are not tests. The intention is for them to be a tool for you to use during development.

If you would like a hand interpreting the results come chat with us in #serverless-agent in the internal DataDog slack or in #serverless in the public DataDog slack. We're happy to help!

Benchmark stats
goos: linux
goarch: amd64
pkg: github.com/DataDog/datadog-agent/pkg/serverless/daemon
cpu: AMD EPYC 7763 64-Core Processor                
                                      │ baseline/benchmark.log │        current/benchmark.log        │
                                      │         sec/op         │    sec/op     vs base               │
api-gateway-appsec.json                            83.87µ ± 2%    85.76µ ± 1%  +2.25% (p=0.015 n=10)
api-gateway-kong-appsec.json                       65.26µ ± 2%    66.59µ ± 4%  +2.03% (p=0.009 n=10)
api-gateway-kong.json                              62.24µ ± 1%    63.66µ ± 1%  +2.27% (p=0.000 n=10)
api-gateway-non-proxy-async.json                   98.03µ ± 1%   101.31µ ± 2%  +3.34% (p=0.000 n=10)
api-gateway-non-proxy.json                         97.00µ ± 2%   101.10µ ± 3%  +4.23% (p=0.000 n=10)
api-gateway-websocket-connect.json                 63.20µ ± 0%    64.64µ ± 1%  +2.29% (p=0.000 n=10)
api-gateway-websocket-default.json                 56.80µ ± 3%    57.66µ ± 1%       ~ (p=0.218 n=10)
api-gateway-websocket-disconnect.json              56.65µ ± 1%    58.78µ ± 1%  +3.76% (p=0.000 n=10)
api-gateway.json                                   104.5µ ± 1%    107.5µ ± 1%  +2.88% (p=0.000 n=10)
application-load-balancer.json                     57.27µ ± 2%    58.45µ ± 1%  +2.06% (p=0.002 n=10)
cloudfront.json                                    42.77µ ± 1%    44.19µ ± 1%  +3.33% (p=0.000 n=10)
cloudwatch-events.json                             36.27µ ± 1%    37.08µ ± 1%  +2.24% (p=0.000 n=10)
cloudwatch-logs.json                               61.20µ ± 3%    60.83µ ± 2%       ~ (p=0.739 n=10)
custom.json                                        30.55µ ± 3%    31.32µ ± 2%  +2.51% (p=0.009 n=10)
dynamodb.json                                      84.57µ ± 2%    85.04µ ± 1%       ~ (p=0.353 n=10)
empty.json                                         28.94µ ± 1%    29.33µ ± 1%  +1.34% (p=0.001 n=10)
eventbridge-custom.json                            45.07µ ± 1%    46.00µ ± 1%  +2.06% (p=0.000 n=10)
eventbridge-no-bus.json                            44.20µ ± 1%    44.61µ ± 1%       ~ (p=0.165 n=10)
eventbridge-no-timestamp.json                      44.22µ ± 1%    44.62µ ± 1%  +0.90% (p=0.043 n=10)
eventbridgesns.json                                58.32µ ± 2%    58.96µ ± 1%  +1.10% (p=0.043 n=10)
eventbridgesqs.json                                64.64µ ± 1%    65.05µ ± 2%       ~ (p=0.105 n=10)
http-api.json                                      63.54µ ± 1%    64.64µ ± 1%  +1.72% (p=0.000 n=10)
kinesis-batch.json                                 64.41µ ± 1%    64.88µ ± 1%  +0.74% (p=0.024 n=10)
kinesis.json                                       50.60µ ± 1%    51.86µ ± 1%  +2.48% (p=0.000 n=10)
s3.json                                            55.09µ ± 1%    55.33µ ± 2%       ~ (p=0.218 n=10)
sns-batch.json                                     81.26µ ± 1%    82.63µ ± 2%  +1.69% (p=0.000 n=10)
sns.json                                           61.67µ ± 0%    61.68µ ± 1%       ~ (p=0.481 n=10)
snssqs.json                                        103.5µ ± 1%    105.4µ ± 2%  +1.89% (p=0.002 n=10)
snssqs_no_dd_context.json                          94.42µ ± 1%    95.56µ ± 2%       ~ (p=0.123 n=10)
sqs-aws-header.json                                51.95µ ± 1%    51.97µ ± 1%       ~ (p=0.853 n=10)
sqs-batch.json                                     84.49µ ± 1%    85.33µ ± 2%  +0.99% (p=0.009 n=10)
sqs.json                                           63.09µ ± 1%    63.07µ ± 1%       ~ (p=1.000 n=10)
sqs_no_dd_context.json                             57.54µ ± 1%    57.46µ ± 1%       ~ (p=0.912 n=10)
stepfunction.json                                  40.72µ ± 2%    40.67µ ± 2%       ~ (p=0.739 n=10)
geomean                                            60.29µ         61.21µ       +1.54%

                                      │ baseline/benchmark.log │        current/benchmark.log        │
                                      │          B/op          │     B/op      vs base               │
api-gateway-appsec.json                           37.40Ki ± 0%   37.40Ki ± 0%       ~ (p=0.160 n=10)
api-gateway-kong-appsec.json                      27.13Ki ± 0%   27.13Ki ± 0%       ~ (p=0.398 n=10)
api-gateway-kong.json                             24.61Ki ± 0%   24.62Ki ± 0%       ~ (p=0.539 n=10)
api-gateway-non-proxy-async.json                  47.98Ki ± 0%   47.99Ki ± 0%       ~ (p=0.697 n=10)
api-gateway-non-proxy.json                        47.19Ki ± 0%   47.19Ki ± 0%  -0.01% (p=0.017 n=10)
api-gateway-websocket-connect.json                25.37Ki ± 0%   25.37Ki ± 0%       ~ (p=0.503 n=10)
api-gateway-websocket-default.json                20.09Ki ± 0%   20.09Ki ± 0%       ~ (p=0.667 n=10)
api-gateway-websocket-disconnect.json             21.00Ki ± 0%   21.00Ki ± 0%       ~ (p=0.441 n=10)
api-gateway.json                                  49.18Ki ± 0%   49.17Ki ± 0%       ~ (p=0.324 n=10)
application-load-balancer.json                    23.40Ki ± 0%   23.40Ki ± 0%  -0.01% (p=0.022 n=10)
cloudfront.json                                   17.48Ki ± 0%   17.48Ki ± 0%       ~ (p=0.146 n=10)
cloudwatch-events.json                            11.55Ki ± 0%   11.55Ki ± 0%       ~ (p=0.308 n=10)
cloudwatch-logs.json                              53.08Ki ± 0%   53.07Ki ± 0%  -0.01% (p=0.011 n=10)
custom.json                                       9.572Ki ± 0%   9.572Ki ± 0%       ~ (p=1.000 n=10)
dynamodb.json                                     40.37Ki ± 0%   40.37Ki ± 0%       ~ (p=0.627 n=10)
empty.json                                        9.110Ki ± 0%   9.110Ki ± 0%       ~ (p=1.000 n=10)
eventbridge-custom.json                           14.73Ki ± 0%   14.73Ki ± 0%       ~ (p=0.513 n=10)
eventbridge-no-bus.json                           13.70Ki ± 0%   13.70Ki ± 0%       ~ (p=0.160 n=10)
eventbridge-no-timestamp.json                     13.70Ki ± 0%   13.70Ki ± 0%       ~ (p=0.739 n=10)
eventbridgesns.json                               20.50Ki ± 0%   20.50Ki ± 0%       ~ (p=0.289 n=10)
eventbridgesqs.json                               24.63Ki ± 0%   24.63Ki ± 0%       ~ (p=0.060 n=10)
http-api.json                                     23.46Ki ± 0%   23.46Ki ± 0%       ~ (p=0.847 n=10)
kinesis-batch.json                                26.57Ki ± 0%   26.57Ki ± 0%       ~ (p=0.751 n=10)
kinesis.json                                      17.45Ki ± 0%   17.44Ki ± 0%       ~ (p=0.075 n=10)
s3.json                                           19.96Ki ± 0%   19.96Ki ± 0%       ~ (p=0.961 n=10)
sns-batch.json                                    39.13Ki ± 0%   39.13Ki ± 0%       ~ (p=0.836 n=10)
sns.json                                          24.57Ki ± 0%   24.57Ki ± 0%       ~ (p=0.596 n=10)
snssqs.json                                       52.81Ki ± 0%   52.81Ki ± 0%       ~ (p=0.076 n=10)
snssqs_no_dd_context.json                         46.57Ki ± 0%   46.56Ki ± 0%       ~ (p=0.303 n=10)
sqs-aws-header.json                               18.80Ki ± 0%   18.80Ki ± 0%       ~ (p=0.780 n=10)
sqs-batch.json                                    41.34Ki ± 0%   41.34Ki ± 0%       ~ (p=0.146 n=10)
sqs.json                                          25.44Ki ± 0%   25.44Ki ± 0%       ~ (p=0.221 n=10)
sqs_no_dd_context.json                            21.09Ki ± 0%   21.09Ki ± 0%       ~ (p=0.395 n=10)
stepfunction.json                                 13.53Ki ± 0%   13.53Ki ± 0%       ~ (p=0.773 n=10)
geomean                                           24.16Ki        24.16Ki       -0.00%

                                      │ baseline/benchmark.log │        current/benchmark.log        │
                                      │       allocs/op        │ allocs/op   vs base                 │
api-gateway-appsec.json                             637.0 ± 0%   637.0 ± 0%       ~ (p=1.000 n=10) ¹
api-gateway-kong-appsec.json                        495.0 ± 0%   495.0 ± 0%       ~ (p=1.000 n=10) ¹
api-gateway-kong.json                               473.0 ± 0%   473.0 ± 0%       ~ (p=1.000 n=10) ¹
api-gateway-non-proxy-async.json                    738.0 ± 0%   738.0 ± 0%       ~ (p=1.000 n=10) ¹
api-gateway-non-proxy.json                          728.0 ± 0%   728.0 ± 0%       ~ (p=1.000 n=10) ¹
api-gateway-websocket-connect.json                  455.0 ± 0%   455.0 ± 0%       ~ (p=1.000 n=10) ¹
api-gateway-websocket-default.json                  376.0 ± 0%   376.0 ± 0%       ~ (p=1.000 n=10) ¹
api-gateway-websocket-disconnect.json               368.0 ± 0%   368.0 ± 0%       ~ (p=1.000 n=10) ¹
api-gateway.json                                    799.0 ± 0%   799.0 ± 0%       ~ (p=1.000 n=10) ¹
application-load-balancer.json                      353.0 ± 0%   353.0 ± 0%       ~ (p=1.000 n=10) ¹
cloudfront.json                                     278.0 ± 0%   278.0 ± 0%       ~ (p=1.000 n=10) ¹
cloudwatch-events.json                              215.0 ± 0%   215.0 ± 0%       ~ (p=1.000 n=10) ¹
cloudwatch-logs.json                                208.0 ± 0%   208.0 ± 0%       ~ (p=1.000 n=10) ¹
custom.json                                         163.0 ± 0%   163.0 ± 0%       ~ (p=1.000 n=10) ¹
dynamodb.json                                       581.0 ± 0%   581.0 ± 0%       ~ (p=1.000 n=10) ¹
empty.json                                          154.0 ± 0%   154.0 ± 0%       ~ (p=1.000 n=10) ¹
eventbridge-custom.json                             260.0 ± 0%   260.0 ± 0%       ~ (p=1.000 n=10) ¹
eventbridge-no-bus.json                             251.0 ± 0%   251.0 ± 0%       ~ (p=1.000 n=10) ¹
eventbridge-no-timestamp.json                       251.0 ± 0%   251.0 ± 0%       ~ (p=1.000 n=10) ¹
eventbridgesns.json                                 315.0 ± 0%   315.0 ± 0%       ~ (p=1.000 n=10) ¹
eventbridgesqs.json                                 355.0 ± 0%   355.0 ± 0%       ~ (p=1.000 n=10) ¹
http-api.json                                       431.0 ± 0%   431.0 ± 0%       ~ (p=1.000 n=10) ¹
kinesis-batch.json                                  382.0 ± 0%   382.0 ± 0%       ~ (p=1.000 n=10) ¹
kinesis.json                                        278.0 ± 0%   278.0 ± 0%       ~ (p=1.000 n=10) ¹
s3.json                                             350.0 ± 0%   350.0 ± 0%       ~ (p=1.000 n=10) ¹
sns-batch.json                                      466.0 ± 0%   466.0 ± 0%       ~ (p=1.000 n=10) ¹
sns.json                                            337.0 ± 0%   337.0 ± 0%       ~ (p=1.000 n=10) ¹
snssqs.json                                         459.0 ± 0%   459.0 ± 0%       ~ (p=1.000 n=10) ¹
snssqs_no_dd_context.json                           419.0 ± 0%   419.0 ± 0%       ~ (p=1.000 n=10) ¹
sqs-aws-header.json                                 275.0 ± 0%   275.0 ± 0%       ~ (p=1.000 n=10) ¹
sqs-batch.json                                      501.0 ± 0%   501.0 ± 0%       ~ (p=1.000 n=10) ¹
sqs.json                                            350.0 ± 0%   350.0 ± 0%       ~ (p=1.000 n=10) ¹
sqs_no_dd_context.json                              336.0 ± 0%   336.0 ± 0%       ~ (p=1.000 n=10) ¹
stepfunction.json                                   223.0 ± 0%   223.0 ± 0%       ~ (p=1.000 n=10) ¹
geomean                                             360.1        360.1       +0.00%
¹ all samples are equal

@genesor
Copy link
Author

genesor commented Feb 13, 2025

/merge

@dd-devflow
Copy link

dd-devflow bot commented Feb 13, 2025

View all feedbacks in Devflow UI.
2025-02-13 15:45:34 UTC ℹ️ Start processing command /merge


2025-02-13 15:45:41 UTC ℹ️ MergeQueue: waiting for PR to be ready

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.


2025-02-13 15:53:50 UTC ⚠️ MergeQueue: This merge request was unqueued

[email protected] unqueued this merge request

@genesor
Copy link
Author

genesor commented Feb 13, 2025

/remove

@dd-devflow
Copy link

dd-devflow bot commented Feb 13, 2025

View all feedbacks in Devflow UI.
2025-02-13 15:53:38 UTC ℹ️ Start processing command /remove


2025-02-13 15:53:54 UTC ℹ️ Devflow: /remove

@genesor
Copy link
Author

genesor commented Feb 13, 2025

/merge

@dd-devflow
Copy link

dd-devflow bot commented Feb 13, 2025

View all feedbacks in Devflow UI.
2025-02-13 15:54:28 UTC ℹ️ Start processing command /merge
Use /merge -c to cancel this operation!


2025-02-13 15:54:35 UTC ℹ️ MergeQueue: waiting for PR to be ready

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.

Use /merge -c to cancel this operation!


⏳ Processing ...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog component/system-probe long review PR is complex, plan time to review it qa/no-code-change No code change in Agent code requiring validation team/agent-appsec
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants