Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add StartExperimentInstaller LocalAPI Command #33802

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

jack0x2
Copy link
Contributor

@jack0x2 jack0x2 commented Feb 6, 2025

What does this PR do?

Adds a local API command to call the StartInstallerExperiment Code path for the daemon from the local_api.

Motivation

https://datadoghq.atlassian.net/browse/WINA-1291

This helps with testing changes to experiment installer updates. On windows it helps tests service shutdowns and other such commands.

Describe how you validated your changes

New API validated via added unit test and manual tested with following steps:

  • update catalog to include a new package for an update of the datadog-installer
  • run the deamon command with start-installer-experiment and version and product for the update
  • Verify that it successfully updated.

e2e test updated from start-experiment to start-installer-experiment for where it install the installer.

Possible Drawbacks / Trade-offs

Additional Notes

@github-actions github-actions bot added medium review PR review might take time team/windows-agent labels Feb 6, 2025
@agent-platform-auto-pr
Copy link
Contributor

agent-platform-auto-pr bot commented Feb 6, 2025

Uncompressed package size comparison

Comparison with ancestor 909942b64fda2a3bdb7f79562115cde9e3cacd94

Diff per package
package diff status size ancestor threshold
datadog-agent-arm64-deb 0.00MB 861.58MB 861.58MB 0.50MB
datadog-dogstatsd-amd64-deb 0.00MB 59.10MB 59.10MB 0.50MB
datadog-dogstatsd-x86_64-rpm 0.00MB 59.18MB 59.18MB 0.50MB
datadog-dogstatsd-x86_64-suse 0.00MB 59.18MB 59.18MB 0.50MB
datadog-dogstatsd-arm64-deb 0.00MB 56.57MB 56.57MB 0.50MB
datadog-heroku-agent-amd64-deb 0.00MB 445.90MB 445.90MB 0.50MB
datadog-iot-agent-amd64-deb 0.00MB 86.37MB 86.37MB 0.50MB
datadog-iot-agent-x86_64-rpm 0.00MB 86.44MB 86.44MB 0.50MB
datadog-iot-agent-x86_64-suse 0.00MB 86.44MB 86.44MB 0.50MB
datadog-iot-agent-arm64-deb 0.00MB 82.64MB 82.64MB 0.50MB
datadog-iot-agent-aarch64-rpm 0.00MB 82.71MB 82.71MB 0.50MB
datadog-agent-aarch64-rpm -0.00MB 871.30MB 871.30MB 0.50MB
datadog-agent-x86_64-rpm -0.00MB 883.44MB 883.44MB 0.50MB
datadog-agent-x86_64-suse -0.00MB 883.44MB 883.44MB 0.50MB
datadog-agent-amd64-deb -0.00MB 873.70MB 873.70MB 0.50MB

Decision

✅ Passed

@agent-platform-auto-pr
Copy link
Contributor

agent-platform-auto-pr bot commented Feb 6, 2025

Static quality checks ✅

Please find below the results from static quality gates

Info

Result Quality gate On disk size On disk size limit On wire size On wire size limit
static_quality_gate_agent_deb_amd64 845.08MiB 858.45MiB 203.59MiB 214.3MiB
static_quality_gate_docker_agent_amd64 929.36MiB 942.69MiB 310.75MiB 321.56MiB

@agent-platform-auto-pr
Copy link
Contributor

agent-platform-auto-pr bot commented Feb 6, 2025

Test changes on VM

Use this command from test-infra-definitions to manually test this PR changes on a VM:

inv aws.create-vm --pipeline-id=55301363 --os-family=ubuntu

Note: This applies to commit 040aed2

Copy link

cit-pr-commenter bot commented Feb 6, 2025

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: c90f9554-f558-46f8-97b8-56372f7ccf5f

Baseline: 909942b
Comparison: 040aed2
Diff

Optimization Goals: ✅ No significant changes detected

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
file_to_blackhole_500ms_latency egress throughput +0.19 [-0.58, +0.97] 1 Logs
file_to_blackhole_100ms_latency egress throughput +0.14 [-0.60, +0.88] 1 Logs
file_to_blackhole_0ms_latency_http1 egress throughput +0.07 [-0.79, +0.93] 1 Logs
file_to_blackhole_0ms_latency egress throughput +0.03 [-0.88, +0.93] 1 Logs
uds_dogstatsd_to_api ingress throughput +0.01 [-0.27, +0.28] 1 Logs
tcp_dd_logs_filter_exclude ingress throughput +0.00 [-0.01, +0.01] 1 Logs
file_to_blackhole_300ms_latency egress throughput -0.02 [-0.65, +0.62] 1 Logs
quality_gate_idle_all_features memory utilization -0.03 [-0.09, +0.04] 1 Logs bounds checks dashboard
file_to_blackhole_0ms_latency_http2 egress throughput -0.06 [-0.96, +0.84] 1 Logs
file_tree memory utilization -0.16 [-0.23, -0.09] 1 Logs
uds_dogstatsd_to_api_cpu % cpu utilization -0.17 [-1.02, +0.69] 1 Logs
quality_gate_idle memory utilization -0.20 [-0.24, -0.17] 1 Logs bounds checks dashboard
tcp_syslog_to_blackhole ingress throughput -0.26 [-0.33, -0.19] 1 Logs
file_to_blackhole_1000ms_latency egress throughput -0.27 [-1.04, +0.51] 1 Logs
file_to_blackhole_1000ms_latency_linear_load egress throughput -0.34 [-0.80, +0.13] 1 Logs
quality_gate_logs % cpu utilization -2.14 [-5.16, +0.87] 1 Logs

Bounds Checks: ✅ Passed

perf experiment bounds_check_name replicates_passed links
file_to_blackhole_0ms_latency lost_bytes 10/10
file_to_blackhole_0ms_latency memory_usage 10/10
file_to_blackhole_0ms_latency_http1 lost_bytes 10/10
file_to_blackhole_0ms_latency_http1 memory_usage 10/10
file_to_blackhole_0ms_latency_http2 lost_bytes 10/10
file_to_blackhole_0ms_latency_http2 memory_usage 10/10
file_to_blackhole_1000ms_latency memory_usage 10/10
file_to_blackhole_1000ms_latency_linear_load memory_usage 10/10
file_to_blackhole_100ms_latency lost_bytes 10/10
file_to_blackhole_100ms_latency memory_usage 10/10
file_to_blackhole_300ms_latency lost_bytes 10/10
file_to_blackhole_300ms_latency memory_usage 10/10
file_to_blackhole_500ms_latency lost_bytes 10/10
file_to_blackhole_500ms_latency memory_usage 10/10
quality_gate_idle intake_connections 10/10 bounds checks dashboard
quality_gate_idle memory_usage 10/10 bounds checks dashboard
quality_gate_idle_all_features intake_connections 10/10 bounds checks dashboard
quality_gate_idle_all_features memory_usage 10/10 bounds checks dashboard
quality_gate_logs intake_connections 10/10
quality_gate_logs lost_bytes 10/10
quality_gate_logs memory_usage 10/10

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

Passed. All Quality Gates passed.

  • quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.

@jack0x2 jack0x2 added qa/done QA done before merge and regressions are covered by tests changelog/no-changelog labels Feb 7, 2025
@jack0x2 jack0x2 marked this pull request as ready for review February 7, 2025 22:21
@jack0x2 jack0x2 requested review from a team as code owners February 7, 2025 22:21
if err != nil {
return err
}
req, err := http.NewRequest(http.MethodPost, fmt.Sprintf("http://%s/%s/experiment/start-installer", c.addr, pkg), bytes.NewBuffer(body))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: is this the only line that's different from StartExperiment ? Could we combine them?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog medium review PR review might take time qa/done QA done before merge and regressions are covered by tests team/windows-agent
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants