Fix and reapply "chore(apm): consolidate External Data Origin Detection" #33832
+63
−44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Wassim DHIF <[email protected]>
wdhif
added
changelog/no-changelog
qa/done
wdhif
changed the title
wdhif
changed the title
ichinaski
approved these changes
Feb 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Reapply #33703.
Fixed by using
NoopContainerIDFromOriginInfoFuncand #33819To avoid the same issue as #33703, PR was tested using
deva pipeline.run --deploy --hereMotivation
Reapply #33703.
Describe how you validated your changes
QA is done by unit and E2E tests. It was also done manually.
Possible Drawbacks / Trade-offs
None
Additional Notes
N/A