Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove exe files from setuptools on non-Windows platforms from the package #33850

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

FlorentClarret
Copy link
Member

@FlorentClarret FlorentClarret commented Feb 10, 2025

What does this PR do?

Remove exe files from setuptools on non-Windows platforms from the package

Motivation

We don't really need them

Describe how you validated your changes

Possible Drawbacks / Trade-offs

Additional Notes

@FlorentClarret FlorentClarret requested a review from a team as a code owner February 10, 2025 06:52
@FlorentClarret FlorentClarret force-pushed the florentclarret/remove-exe-files branch from cab3db5 to 1838ed8 Compare February 10, 2025 06:53
@github-actions github-actions bot added short review PR is simple enough to be reviewed quickly team/agent-delivery labels Feb 10, 2025
@FlorentClarret FlorentClarret added changelog/no-changelog qa/no-code-change No code change in Agent code requiring validation labels Feb 10, 2025
@agent-platform-auto-pr
Copy link
Contributor

agent-platform-auto-pr bot commented Feb 10, 2025

Static quality checks ✅

Please find below the results from static quality gates

Info

Result Quality gate On disk size On disk size limit On wire size On wire size limit
static_quality_gate_agent_deb_amd64 844.9MiB 858.45MiB 203.59MiB 214.3MiB
static_quality_gate_docker_agent_amd64 929.26MiB 942.69MiB 310.69MiB 321.56MiB

@agent-platform-auto-pr
Copy link
Contributor

agent-platform-auto-pr bot commented Feb 10, 2025

Uncompressed package size comparison

Comparison with ancestor 26f96c8554a5546acd016da35c60ba45330b7d38

Diff per package
package diff status size ancestor threshold
datadog-dogstatsd-amd64-deb 0.00MB 59.10MB 59.10MB 0.50MB
datadog-dogstatsd-x86_64-rpm 0.00MB 59.18MB 59.18MB 0.50MB
datadog-dogstatsd-x86_64-suse 0.00MB 59.18MB 59.18MB 0.50MB
datadog-dogstatsd-arm64-deb 0.00MB 56.57MB 56.57MB 0.50MB
datadog-iot-agent-amd64-deb 0.00MB 86.38MB 86.38MB 0.50MB
datadog-iot-agent-x86_64-rpm 0.00MB 86.45MB 86.45MB 0.50MB
datadog-iot-agent-x86_64-suse 0.00MB 86.45MB 86.45MB 0.50MB
datadog-iot-agent-arm64-deb 0.00MB 82.65MB 82.65MB 0.50MB
datadog-iot-agent-aarch64-rpm 0.00MB 82.72MB 82.72MB 0.50MB
datadog-agent-amd64-deb -0.10MB 873.60MB 873.71MB 0.50MB
datadog-heroku-agent-amd64-deb -0.10MB 445.81MB 445.91MB 0.50MB
datadog-agent-x86_64-rpm -0.10MB 883.34MB 883.45MB 0.50MB
datadog-agent-x86_64-suse -0.10MB 883.34MB 883.45MB 0.50MB
datadog-agent-aarch64-rpm -0.10MB 871.20MB 871.30MB 0.50MB
datadog-agent-arm64-deb -0.10MB 861.48MB 861.58MB 0.50MB

Decision

✅ Passed

@agent-platform-auto-pr
Copy link
Contributor

agent-platform-auto-pr bot commented Feb 10, 2025

[Fast Unit Tests Report]

On pipeline 55384957 (CI Visibility). The following jobs did not run any unit tests:

Jobs:
  • tests_deb-arm64-py3
  • tests_deb-x64-py3
  • tests_flavor_dogstatsd_deb-x64
  • tests_flavor_heroku_deb-x64
  • tests_flavor_iot_deb-x64
  • tests_rpm-arm64-py3
  • tests_rpm-x64-py3
  • tests_windows-x64

If you modified Go files and expected unit tests to run in these jobs, please double check the job logs. If you think tests should have been executed reach out to #agent-devx-help

Copy link

cit-pr-commenter bot commented Feb 10, 2025

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: fd51c5f1-44f4-4092-b702-f1396b47917a

Baseline: 26f96c8
Comparison: 8d53e8d
Diff

Optimization Goals: ✅ No significant changes detected

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
quality_gate_logs % cpu utilization +2.11 [-0.99, +5.20] 1 Logs
quality_gate_idle_all_features memory utilization +0.60 [+0.53, +0.66] 1 Logs bounds checks dashboard
file_tree memory utilization +0.24 [+0.17, +0.32] 1 Logs
file_to_blackhole_1000ms_latency egress throughput +0.22 [-0.55, +1.00] 1 Logs
file_to_blackhole_1000ms_latency_linear_load egress throughput +0.16 [-0.31, +0.62] 1 Logs
file_to_blackhole_500ms_latency egress throughput +0.06 [-0.73, +0.85] 1 Logs
file_to_blackhole_0ms_latency_http1 egress throughput +0.04 [-0.78, +0.86] 1 Logs
file_to_blackhole_0ms_latency_http2 egress throughput +0.04 [-0.83, +0.91] 1 Logs
file_to_blackhole_300ms_latency egress throughput -0.00 [-0.64, +0.63] 1 Logs
tcp_dd_logs_filter_exclude ingress throughput -0.01 [-0.02, +0.01] 1 Logs
uds_dogstatsd_to_api ingress throughput -0.02 [-0.32, +0.28] 1 Logs
file_to_blackhole_0ms_latency egress throughput -0.03 [-0.92, +0.86] 1 Logs
file_to_blackhole_100ms_latency egress throughput -0.03 [-0.62, +0.56] 1 Logs
tcp_syslog_to_blackhole ingress throughput -0.16 [-0.21, -0.10] 1 Logs
quality_gate_idle memory utilization -1.04 [-1.10, -0.98] 1 Logs bounds checks dashboard
uds_dogstatsd_to_api_cpu % cpu utilization -2.99 [-3.84, -2.13] 1 Logs

Bounds Checks: ✅ Passed

perf experiment bounds_check_name replicates_passed links
file_to_blackhole_0ms_latency lost_bytes 10/10
file_to_blackhole_0ms_latency memory_usage 10/10
file_to_blackhole_0ms_latency_http1 lost_bytes 10/10
file_to_blackhole_0ms_latency_http1 memory_usage 10/10
file_to_blackhole_0ms_latency_http2 lost_bytes 10/10
file_to_blackhole_0ms_latency_http2 memory_usage 10/10
file_to_blackhole_1000ms_latency memory_usage 10/10
file_to_blackhole_1000ms_latency_linear_load memory_usage 10/10
file_to_blackhole_100ms_latency lost_bytes 10/10
file_to_blackhole_100ms_latency memory_usage 10/10
file_to_blackhole_300ms_latency lost_bytes 10/10
file_to_blackhole_300ms_latency memory_usage 10/10
file_to_blackhole_500ms_latency lost_bytes 10/10
file_to_blackhole_500ms_latency memory_usage 10/10
quality_gate_idle intake_connections 10/10 bounds checks dashboard
quality_gate_idle memory_usage 10/10 bounds checks dashboard
quality_gate_idle_all_features intake_connections 10/10 bounds checks dashboard
quality_gate_idle_all_features memory_usage 10/10 bounds checks dashboard
quality_gate_logs intake_connections 10/10
quality_gate_logs lost_bytes 10/10
quality_gate_logs memory_usage 10/10

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

Passed. All Quality Gates passed.

  • quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.

@FlorentClarret FlorentClarret force-pushed the florentclarret/remove-exe-files branch from 5e75852 to 73c7670 Compare February 10, 2025 09:35
@FlorentClarret FlorentClarret requested a review from a team as a code owner February 10, 2025 09:35
@FlorentClarret FlorentClarret force-pushed the florentclarret/remove-exe-files branch from 73c7670 to ec3ed7a Compare February 10, 2025 10:23
@FlorentClarret FlorentClarret removed the request for review from a team February 10, 2025 10:32
@FlorentClarret FlorentClarret force-pushed the florentclarret/remove-exe-files branch from ec3ed7a to 8d53e8d Compare February 10, 2025 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog qa/no-code-change No code change in Agent code requiring validation short review PR is simple enough to be reviewed quickly team/agent-delivery
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant