Add type annotations to Dogstatsd.timed function and TimedContextManagerDecorator class #866
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements for Contributing to this repository
What does this PR do?
Fixes #797 by adding some types to
Dogstatsd.timed()
function.Description of the Change
Dogstatsd.timed()
function andTimedContextDecoratorManager
.timed
as a decorator, but typing that correctly requires features (typing.TypeVar
,typing.ParamSpec
andtyping.overload
) that are not available in earlier versions of Python supported by this library.Alternate Designs
N/A
Possible Drawbacks
None.
Verification Process
Ran
tox -e mypy
and ensured it passed.Additional Notes
Release Notes
Review checklist (to be filled by reviewers)
changelog/
label attached. If applicable it should have thebackward-incompatible
label attached.do-not-merge/
label attached.kind/
andseverity/
labels attached at least.