feat: Support disabling INV, custom INV values, and FBC for Flutter #2212
+455
−22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds an internal method - `setInternalViewAttribute` - which modifies a specific attribute collection for views. This attribute collection is checked for custom INV Values (if INV is disabled) and Flutter First Build Complete metrics. This also adds the ability to disable INV by setting its last action predicate to `false` refs: RUM-8548
Co-authored-by: Maciek Grzybowski <[email protected]>
Co-authored-by: Barbora Plašovská <[email protected]>
# Conflicts: # DatadogRUM/Tests/RUMMonitor/Scopes/RUMViewScopeTests.swift
fuzzybinary
force-pushed
the
jward/RUM-8546-first-build-complete
branch
from
0626367 to
3df99d1
Compare
Datadog ReportBranch report: ✅ 0 Failed, 742 Passed, 3090 Skipped, 50.19s Total duration (1m 45.94s time saved) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What and why?
This adds an internal method -
setInternalViewAttribute- which modifies a specific attribute collection for views. This attribute collection is checked for custom INV Values and Flutter First Build Complete metrics.This also adds the ability to disable INV by setting its
lastActionPredicateto nil, which has the factory return a nil INVMetricTracking object.refs: RUM-8548
How?
A brief description of implementation details of this PR.
Review checklist
make api-surface)