Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Improve the performance of the deep clone function that is used for event mappers.
If we need to increase the depth of clones again, we can also look at dropping some keys from the clone: for the
actionEventMapper
, what takes a lot of cloning time is theactionContext
containing a lot of circular references.Dropping this field from the cloned object would also significantly reduce the impact on performance, but is a bit less straightforward than just decreasing the max object depth.
Motivation
Currently adding an
actionEventMapper
slows apps down on user interactions: #514Review checklist (to be filled by reviewers)