RUM-449: Enable RUM and Traces for Logs #601
Conversation
jonathanmos
force-pushed
the
jmoskovich/rum-449/leverage-rum-and-traces
branch
3 times, most recently
from
d87a4ab to
7808272
Compare
jonathanmos
force-pushed
the
jmoskovich/rum-449/leverage-rum-and-traces
branch
2 times, most recently
from
c598c0b to
d8749e0
Compare
jonathanmos
force-pushed
the
jmoskovich/rum-449/leverage-rum-and-traces
branch
from
d8749e0 to
2d114a1
Compare
packages/core/android/src/main/kotlin/com/datadog/reactnative/DatadogSDKWrapper.kt
Outdated
Show resolved
Hide resolved
packages/core/android/src/main/kotlin/com/datadog/reactnative/DatadogSDKWrapper.kt
Outdated
Show resolved
Hide resolved
packages/core/android/src/main/kotlin/com/datadog/reactnative/DdSdkImplementation.kt
Outdated
Show resolved
Hide resolved
packages/core/android/src/main/kotlin/com/datadog/reactnative/DdSdkReactNativePackage.kt
Outdated
Show resolved
Hide resolved
packages/core/android/src/main/kotlin/com/datadog/reactnative/DdSdkImplementation.kt
Outdated
Show resolved
Hide resolved
packages/core/android/src/main/kotlin/com/datadog/reactnative/DatadogSDKWrapper.kt
Outdated
Show resolved
Hide resolved
packages/core/android/src/main/kotlin/com/datadog/reactnative/DatadogWrapper.kt
Outdated
Show resolved
Hide resolved
packages/core/android/src/main/kotlin/com/datadog/reactnative/DdSdkImplementation.kt
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
The Android part looks good to me.
Let's wait for the iOS part to be done before merging.
One small improvement we could have made: here there is no reason to pass the config fields in the additionalConfig object. By doing so we lose a tiny bit of type safety, but it's not a huge deal.
Although I think that if they're not needed we should remove the fields from the DdSdkConfiguration since we are not reading them from here as it can be misleading.
Ultimately we should get rid of this additionalConfig field in a separate PR.
| configuration.bundleLogsWithRum, | ||
| configuration.bundleLogsWithTraces |
There was a problem hiding this comment.
Do we also need to pass the data here since we seem to get it from the additionalConfig field anyway?
|
I'm closing this PR for clarity, since the work is going to continue on #624 |
What does this PR do?
A brief description of the change being made with this pull request.
Motivation
What inspired you to submit this pull request?
Additional Notes
Anything else we should know when reviewing?
Review checklist (to be filled by reviewers)