Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RUM-4479] Update Android & iOS SDKs #677

Merged
merged 3 commits into from
Jun 28, 2024
Merged

[RUM-4479] Update Android & iOS SDKs #677

merged 3 commits into from
Jun 28, 2024

Conversation

marco-saia-datadog
Copy link
Member

What does this PR do?

Updates Android SDK to 2.10.1 and iOS SDK to 2.13.0.

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)
  • If this PR is auto-generated, please make sure also to manually update the code related to the change

@marco-saia-datadog marco-saia-datadog force-pushed the marcosaia/RUM-4479/update-sdks branch 13 times, most recently from ba69246 to ab89091 Compare June 27, 2024 16:54
@marco-saia-datadog marco-saia-datadog marked this pull request as ready for review June 27, 2024 17:13
@marco-saia-datadog marco-saia-datadog requested a review from a team as a code owner June 27, 2024 17:13
0xnm
0xnm approved these changes Jun 27, 2024
View reviewed changes
Copy link
Member

@0xnm 0xnm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice! the only suggestion is to use Android SDK 2.11.0

packages/core/android/build.gradle Outdated Show resolved Hide resolved
packages/react-native-session-replay/android/build.gradle Outdated Show resolved Hide resolved
@marco-saia-datadog marco-saia-datadog force-pushed the marcosaia/RUM-4479/update-sdks branch 2 times, most recently from 60106ee to 94f2980 Compare June 28, 2024 08:37
@marco-saia-datadog marco-saia-datadog merged commit 8b325de into develop Jun 28, 2024
6 checks passed
@marco-saia-datadog marco-saia-datadog deleted the marcosaia/RUM-4479/update-sdks branch June 28, 2024 09:58
@marco-saia-datadog marco-saia-datadog mentioned this pull request Jul 4, 2024
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xnm 0xnm 0xnm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@marco-saia-datadog @0xnm